corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1817997 - Reduce precision when storing time related to the played attribute. r=alwu

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D173528
This commit is contained in:
Paul Adenot
2023-05-24 13:18:42 +00:00
parent 4dbcbead01
commit fcd4b24422
3 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dom/html/HTMLMediaElement.cpp
View File

@@ -3200,7 +3200,9 @@ void HTMLMediaElement::Seek(double aTime, SeekTarget::Type aSeekType,
mCurrentPlayRangeStart, rangeEndTime));
// Multiple seek without playing, or seek while playing.
if (mCurrentPlayRangeStart != rangeEndTime) {
mPlayed->Add(mCurrentPlayRangeStart, rangeEndTime);
// Don't round the left of the interval: it comes from script and needs
// to be exact.
mPlayed->Add(mCurrentPlayRangeStart, ToMicrosecondResolution(rangeEndTime));
}
// Reset the current played range start time. We'll re-set it once
// the seek completes.
@@ -3292,7 +3294,11 @@ double HTMLMediaElement::Duration() const {
if (mDecoder) {
// Limit resolution to microsecond.
return std::round(mDecoder->GetDuration() * 1000000.) / 1000000;
double duration = mDecoder->GetDuration();
if (IsFinite<double>(duration)) {
return ToMicrosecondResolution(mDecoder->GetDuration());
}
return duration;
}
return std::numeric_limits<double>::quiet_NaN();
@@ -3321,7 +3327,9 @@ already_AddRefed<TimeRanges> HTMLMediaElement::Played() {
if (mCurrentPlayRangeStart != -1.0) {
double now = CurrentTime();
if (mCurrentPlayRangeStart != now) {
ranges->Add(mCurrentPlayRangeStart, now);
// Don't round the left of the interval: it comes from script and needs
// to be exact.
ranges->Add(mCurrentPlayRangeStart, ToMicrosecondResolution(now));
}
}