corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1693541 - Improve uses of nsBaseHashtable and descendants and avoid multiple subsequent lookups in dom/html. r=mattwoodrow

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D106112
This commit is contained in:
Simon Giesecke
2021-03-01 09:59:29 +00:00
parent 897a87f4e0
commit fba5f29d05
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
dom/html/HTMLFormElement.cpp
View File

@@ -2177,16 +2177,15 @@ uint32_t HTMLFormElement::GetRequiredRadioCount(const nsAString& aName) const {
void HTMLFormElement::RadioRequiredWillChange(const nsAString& aName,
bool aRequiredAdded) {
if (aRequiredAdded) {
mRequiredRadioButtonCounts.InsertOrUpdate(
aName, mRequiredRadioButtonCounts.Get(aName) + 1);
mRequiredRadioButtonCounts.LookupOrInsert(aName, 0) += 1;
} else {
uint32_t requiredNb = mRequiredRadioButtonCounts.Get(aName);
NS_ASSERTION(requiredNb >= 1,
auto requiredNb = mRequiredRadioButtonCounts.Lookup(aName);
NS_ASSERTION(requiredNb && *requiredNb >= 1,
"At least one radio button has to be required!");
if (requiredNb == 1) {
mRequiredRadioButtonCounts.Remove(aName);
if (*requiredNb == 1) {
requiredNb.Remove();
} else {
mRequiredRadioButtonCounts.InsertOrUpdate(aName, requiredNb - 1);
*requiredNb -= 1;
}
}
}