corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1666485 - Make BrowsingContext::CreatedDynamically non-synced, r=nika,kmag

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D89223
This commit is contained in:
Kashav Madan
2020-09-23 12:45:38 +00:00
parent 29d809f6f4
commit fb01408d2e
9 changed files with 57 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
docshell/base/nsDocShell.cpp
View File

@@ -2943,8 +2943,7 @@ nsDocShell::AddChild(nsIDocShellTreeItem* aChild) {
"child list must not be empty after a successful add");
nsCOMPtr<nsIDocShell> childDocShell = do_QueryInterface(aChild);
bool dynamic = false;
childDocShell->GetCreatedDynamically(&dynamic);
bool dynamic = nsDocShell::Cast(childDocShell)->GetCreatedDynamically();
if (!dynamic) {
nsCOMPtr<nsISHEntry> currentSH;
bool oshe = false;
@@ -3125,20 +3124,6 @@ nsresult nsDocShell::AddChildSHEntryToParent(nsISHEntry* aNewEntry,
return rv;
}
NS_IMETHODIMP
nsDocShell::SetCreatedDynamically(bool aDynamic) {
if (mBrowsingContext) {
Unused << mBrowsingContext->SetCreatedDynamically(aDynamic);
}
return NS_OK;
}
NS_IMETHODIMP
nsDocShell::GetCreatedDynamically(bool* aDynamic) {
*aDynamic = mBrowsingContext && mBrowsingContext->GetCreatedDynamically();
return NS_OK;
}
NS_IMETHODIMP
nsDocShell::GetCurrentSHEntry(nsISHEntry** aEntry, bool* aOSHE) {
*aOSHE = false;