corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1310509 - Call NotifyAsyncPanZoomStarted/Stopped on document containing current scrolling content. r=kats

Browse Source 
We now call NotifyAsyncPanZoomStarted/Stopped precisely on the document
which is being transformed, so we no longer need to notify the child
docshells which was added in Bug 1088559.

Remove the |nsIDocument| argument for ProcessAPZStateChange(), which is not
used anymore.

mActiveAPZTransforms added in bug 1142926 is removed because AccessibleCaret
is the only consumer for AsyncPanZoomStarted/Stopped, and it now defaults to
always show while scrolling, i.e.
"layout.accessiblecaret.always_show_when_scrolling" defaults to true. And I
cannot reproduce the bug even if I turn off the preference.

MozReview-Commit-ID: DiEk2gCIHn2
This commit is contained in:
Ting-Yu Lin
2016-11-04 22:27:02 +08:00
parent f73e1820fa
commit fa0746c0ce
5 changed files with 16 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
docshell/base/nsDocShell.cpp
View File

@@ -3080,15 +3080,6 @@ nsDocShell::NotifyAsyncPanZoomStarted()
mScrollObservers.RemoveElement(ref);
}
}
// Also notify child docshell
for (uint32_t i = 0; i < mChildList.Length(); ++i) {
nsCOMPtr<nsIDocShell> kid = do_QueryInterface(ChildAt(i));
if (kid) {
nsDocShell* docShell = static_cast<nsDocShell*>(kid.get());
docShell->NotifyAsyncPanZoomStarted();
}
}
}
void
@@ -3104,15 +3095,6 @@ nsDocShell::NotifyAsyncPanZoomStopped()
mScrollObservers.RemoveElement(ref);
}
}
// Also notify child docshell
for (uint32_t i = 0; i < mChildList.Length(); ++i) {
nsCOMPtr<nsIDocShell> kid = do_QueryInterface(ChildAt(i));
if (kid) {
nsDocShell* docShell = static_cast<nsDocShell*>(kid.get());
docShell->NotifyAsyncPanZoomStopped();
}
}
}
NS_IMETHODIMP