corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1479173 - Call EffectSet::GetEffectSet in CanThrottle just once. r=birtles

Browse Source 
Depends on D10693

Differential Revision: https://phabricator.services.mozilla.com/D10694
This commit is contained in:
Hiroyuki Ikezoe
2018-11-06 06:21:14 +00:00
parent 73a3b89946
commit f96020fefa
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
dom/animation/KeyframeEffect.cpp
View File

@@ -1248,6 +1248,7 @@ KeyframeEffect::CanThrottle() const
}
}
EffectSet* effectSet = nullptr;
for (const LayerAnimationInfo::Record& record :
LayerAnimationInfo::sRecords) {
// Skip properties that are overridden by !important rules.
@@ -1259,10 +1260,12 @@ KeyframeEffect::CanThrottle() const
continue;
}
EffectSet* effectSet = EffectSet::GetEffectSet(mTarget->mElement,
mTarget->mPseudoType);
MOZ_ASSERT(effectSet, "CanThrottle should be called on an effect "
"associated with a target element");
if (!effectSet) {
effectSet = EffectSet::GetEffectSet(mTarget->mElement,
mTarget->mPseudoType);
MOZ_ASSERT(effectSet, "CanThrottle should be called on an effect "
"associated with a target element");
}
// Note that AnimationInfo::GetGenarationFromFrame() is supposed to work
// with the primary frame instead of the style frame.
Maybe<uint64_t> generation = layers::AnimationInfo::GetGenerationFromFrame(