Bug 1721217 - Part 2: Fix the race between navigations originating in the parent and in the content, r=nika
Add a synced ParentInitiatedNavigationEpoch field to browsing context, which only gets incremented when we start navigations in the parent process. When a child process initiates a navigation, it sends the current value of the field that it sees via DocumentChannelCreationArgs. In the parent process, we can compare the value of that field with the latest one for the same browsing context. If the latest value is higher than the one provided by the content process, it means that in the meantime parent process has started a navigation so the earlier navigation originating in the content process will be cancelled. Differential Revision: https://phabricator.services.mozilla.com/D126842
This commit is contained in:
@@ -70,6 +70,9 @@ static mozilla::LazyLogModule sPBContext("PBContext");
|
||||
// Global count of canonical browsing contexts with the private attribute set
|
||||
static uint32_t gNumberOfPrivateContexts = 0;
|
||||
|
||||
// Current parent process epoch for parent initiated navigations
|
||||
static uint64_t gParentInitiatedNavigationEpoch = 0;
|
||||
|
||||
static void IncreasePrivateCount() {
|
||||
gNumberOfPrivateContexts++;
|
||||
MOZ_LOG(sPBContext, mozilla::LogLevel::Debug,
|
||||
@@ -2043,6 +2046,8 @@ bool CanonicalBrowsingContext::LoadInParent(nsDocShellLoadState* aLoadState,
|
||||
|
||||
MOZ_ASSERT(!net::SchemeIsJavascript(aLoadState->URI()));
|
||||
|
||||
MOZ_ALWAYS_SUCCEEDS(
|
||||
SetParentInitiatedNavigationEpoch(++gParentInitiatedNavigationEpoch));
|
||||
// Note: If successful, this will recurse into StartDocumentLoad and
|
||||
// set mCurrentLoad to the DocumentLoadListener instance created.
|
||||
// Ideally in the future we will only start loads from here, and we can
|
||||
|
||||
Reference in New Issue
Block a user