corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 889599, part 4 - Remove unnecessary JSScript parameter from Parser::standaloneFunctionBody(). r=Waldo.

Browse Source
This commit is contained in:
Jason Orendorff
2013-07-12 12:20:58 -05:00
parent 9c2768c04f
commit f87b72025e
3 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
js/src/frontend/BytecodeCompiler.cpp
View File

@@ -445,12 +445,6 @@ frontend::CompileFunctionBody(JSContext *cx, MutableHandleFunction fun, CompileO
fun->setArgCount(formals.length());
Rooted<JSScript*> script(cx, JSScript::Create(cx, NullPtr(), false, options,
/* staticLevel = */ 0, sourceObject,
/* sourceStart = */ 0, length));
if (!script)
return false;
// If the context is strict, immediately parse the body in strict
// mode. Otherwise, we parse it normally. If we see a "use strict"
// directive, we backup and reparse it as strict.
@@ -460,7 +454,7 @@ frontend::CompileFunctionBody(JSContext *cx, MutableHandleFunction fun, CompileO
bool strict = options.strictOption;
bool becameStrict;
while (true) {
fn = parser.standaloneFunctionBody(fun, formals, script, strict, &becameStrict);
fn = parser.standaloneFunctionBody(fun, formals, strict, &becameStrict);
if (fn)
break;
@@ -500,6 +494,13 @@ frontend::CompileFunctionBody(JSContext *cx, MutableHandleFunction fun, CompileO
}
#endif
Rooted<JSScript*> script(cx, JSScript::Create(cx, NullPtr(), false, options,
/* staticLevel = */ 0, sourceObject,
/* sourceStart = */ 0, length));
if (!script)
return false;
script->bindings = fn->pn_funbox->bindings;
if (generateBytecode) {
/*
* The reason for checking fun->environment() below is that certain