corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 972385 - Make JS::AutoValueVector subscript operator return handles. r=jonco, smaug

Browse Source
This commit is contained in:
Michael Shuen
2014-04-28 16:53:00 +02:00
parent dd0d673225
commit f7ea3d18e8
27 changed files with 74 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
js/ipc/JavaScriptChild.cpp
View File

@@ -501,7 +501,7 @@ JavaScriptChild::AnswerCall(const ObjectId &objId, const nsTArray<JSParam> &argv
ContextOptionsRef(cx).setDontReportUncaught(true);
HandleValueArray args = HandleValueArray::subarray(vals, 2, vals.length() - 2);
bool success = JS::Call(cx, vals.handleAt(1), vals.handleAt(0), args, &rval);
bool success = JS::Call(cx, vals[1], vals[0], args, &rval);
if (!success)
return fail(cx, rs);
}
@@ -536,7 +536,7 @@ JavaScriptChild::AnswerCall(const ObjectId &objId, const nsTArray<JSParam> &argv
// treat this as the outparam never having been set.
for (size_t i = 0; i < vals.length(); i++) {
JSVariant variant;
if (!toVariant(cx, vals.handleAt(i), &variant))
if (!toVariant(cx, vals[i], &variant))
return fail(cx, rs);
outparams->ReplaceElementAt(i, JSParam(variant));
}
@@ -596,7 +596,7 @@ JavaScriptChild::AnswerGetPropertyNames(const ObjectId &objId, const uint32_t &f
for (size_t i = 0; i < props.length(); i++) {
nsString name;
if (!convertIdToGeckoString(cx, props.handleAt(i), &name))
if (!convertIdToGeckoString(cx, props[i], &name))
return fail(cx, rs);
names->AppendElement(name);