corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1398963 part 5: Treat XUL Popups like other OOF boxes when generating anon flex items, since they spawn placeholders. r=mats

Browse Source 
XUL popups (i.e. FrameConstructionItem instances with mIsPopup==true) behave
like out-of-flow content -- in particular, they generate nsPlaceholderFrame
instances.  So, they need the same placeholder-wrapping behavior that we have
for other out-of-flow frames inside of an emulated legacy box, in order to
satisfy our existing invariants.

MozReview-Commit-ID: KnspN4kTPnx
This commit is contained in:
Daniel Holbert
2017-12-18 12:17:10 -06:00
parent c230cb8658
commit f608ba3a3d
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
layout/base/nsCSSFrameConstructor.cpp
View File

@@ -12905,13 +12905,15 @@ nsCSSFrameConstructor::FrameConstructionItem::
// anonymous flex item.
return true;
}
if (!(mFCData->mBits & FCDATA_DISALLOW_OUT_OF_FLOW) &&
aState.GetGeometricParent(mStyleContext->StyleDisplay(), nullptr)) {
// We're abspos or fixedpos, which means we'll spawn a placeholder which
// (because our container is an emulated legacy box) we'll need to wrap
// in an anonymous flex item. So, we just treat _this_ frame as if _it_
// needs to be wrapped in an anonymous flex item, and then when we spawn
// the placeholder, it'll end up in the right spot.
if (mIsPopup ||
(!(mFCData->mBits & FCDATA_DISALLOW_OUT_OF_FLOW) &&
aState.GetGeometricParent(mStyleContext->StyleDisplay(), nullptr))) {
// We're abspos or fixedpos (or a XUL popup), which means we'll spawn a
// placeholder which (because our container is an emulated legacy box)
// we'll need to wrap in an anonymous flex item. So, we just treat
// _this_ frame as if _it_ needs to be wrapped in an anonymous flex item,
// and then when we spawn the placeholder, it'll end up in the right
// spot.
return true;
}
}