corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1482956 - Use an AutoTArray in PaintTask to reduce heap allocations. r=nical

Browse Source 
There should only ever be at most four TextureClients here, so
allocated a vector seems wasteful.
This commit is contained in:
Ryan Hunt
2018-08-13 12:22:18 -05:00
parent 4beb6337f7
commit f47a79aebe
5 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
gfx/layers/client/ContentClient.cpp
View File

@@ -276,9 +276,9 @@ ContentClient::BeginPaint(PaintedLayer* aLayer,
if (result.mAsyncPaint) {
result.mAsyncTask->mTarget = mBuffer->GetBufferTarget();
result.mAsyncTask->mClients.push_back(mBuffer->GetClient());
result.mAsyncTask->mClients.AppendElement(mBuffer->GetClient());
if (mBuffer->GetClientOnWhite()) {
result.mAsyncTask->mClients.push_back(mBuffer->GetClientOnWhite());
result.mAsyncTask->mClients.AppendElement(mBuffer->GetClientOnWhite());
}
}
@@ -887,9 +887,9 @@ ContentClientDoubleBuffered::FinalizeFrame(PaintState& aPaintState)
mBuffer->UpdateDestinationFrom(*mFrontBuffer, updateRegion.GetBounds());
if (aPaintState.mAsyncPaint) {
aPaintState.mAsyncTask->mClients.push_back(mFrontBuffer->GetClient());
aPaintState.mAsyncTask->mClients.AppendElement(mFrontBuffer->GetClient());
if (mFrontBuffer->GetClientOnWhite()) {
aPaintState.mAsyncTask->mClients.push_back(mFrontBuffer->GetClientOnWhite());
aPaintState.mAsyncTask->mClients.AppendElement(mFrontBuffer->GetClientOnWhite());
}
}