From f046a5704941a709ac6d66cbb99ff9d072c920b4 Mon Sep 17 00:00:00 2001 From: Masayuki Nakano Date: Fri, 14 Mar 2025 01:19:47 +0000 Subject: [PATCH] Bug 1952410 - Enable DOM mutation events when running crash tests for the editor module until it's disabled in the release channel r=smaug,m_kato We added a lot of crash tests for tricky cases for the editor module. Some of them use the legacy DOM mutation events, and some of them caused serious issues. Thus, we should enable the DOM mutation events at least running the tests to detect regressions as soon as possible. Differential Revision: https://phabricator.services.mozilla.com/D240709 --- editor/libeditor/crashtests/crashtests.list | 40 +++++++++---------- .../meta/editing/crashtests/__dir__.ini | 1 + .../delete-selection-with-null-range.html} | 0 .../design-mode-textarea.html} | 0 .../empty-editable.html} | 0 ...irst-letter-crossing-engine-boundary.html} | 3 -- testing/web-platform/tests/lint.ignore | 1 - 7 files changed, 21 insertions(+), 24 deletions(-) create mode 100644 testing/web-platform/meta/editing/crashtests/__dir__.ini rename testing/web-platform/tests/editing/{other/delete-selection-with-null-range-crash.html => crashtests/delete-selection-with-null-range.html} (100%) rename testing/web-platform/tests/editing/{other/design-mode-textarea-crash.html => crashtests/design-mode-textarea.html} (100%) rename testing/web-platform/tests/editing/{run/empty-editable-crash.html => crashtests/empty-editable.html} (100%) rename testing/web-platform/tests/editing/{run/first-letter-crossing-engine-boundary-crash.html => crashtests/first-letter-crossing-engine-boundary.html} (74%) diff --git a/editor/libeditor/crashtests/crashtests.list b/editor/libeditor/crashtests/crashtests.list index 64b70aaa8c5e..10b8d3d27e69 100644 --- a/editor/libeditor/crashtests/crashtests.list +++ b/editor/libeditor/crashtests/crashtests.list @@ -2,8 +2,8 @@ defaults pref(test.ime_content_observer.assert_invalid_cache,true) load 336081-1.xhtml load 403965-1.xhtml -load 428489-1.html -load 429586-1.html +pref(dom.mutation_events.enabled,true) load 428489-1.html +pref(dom.mutation_events.enabled,true) load 429586-1.html load 431086-1.xhtml load 475132-1.xhtml load 503709-1.xhtml @@ -37,7 +37,7 @@ load 1158452.html load 1158651.html load 1244894.xhtml load 1264921.html -load 1272490.html +pref(dom.mutation_events.enabled,true) load 1272490.html load 1274050.html load 1317704.html load 1317718.html @@ -57,18 +57,18 @@ load 1383763.html load 1384161.html load 1388075.html load 1393171.html -needs-focus load 1402196.html +pref(dom.mutation_events.enabled,true) needs-focus load 1402196.html load 1402469.html -load 1402526.html -load 1405897.html +pref(dom.mutation_events.enabled,true) load 1402526.html +pref(dom.mutation_events.enabled,true) load 1405897.html load 1408170.html -asserts(0-1) load 1414581.html -load 1415231.html -load 1423767.html -needs-focus load 1423776.html +pref(dom.mutation_events.enabled,true) asserts(0-1) load 1414581.html +pref(dom.mutation_events.enabled,true) load 1415231.html +pref(dom.mutation_events.enabled,true) load 1423767.html +pref(dom.mutation_events.enabled,true) needs-focus load 1423776.html skip-if(ThreadSanitizer) needs-focus load 1424450.html # bug 1718775, permafail on tsan -load 1425091.html -load 1426709.html +pref(dom.mutation_events.enabled,true) load 1425091.html +pref(dom.mutation_events.enabled,true) load 1426709.html needs-focus load 1429523.html needs-focus load 1429523.xhtml load 1441619.html @@ -77,18 +77,18 @@ skip-if(Android) needs-focus load 1444630.html load 1446451.html pref(layout.accessiblecaret.enabled,true) load 1470926.html load 1517028.html -load 1525481.html -load 1533913.html +pref(dom.mutation_events.enabled,true) load 1525481.html +pref(dom.mutation_events.enabled,true) load 1533913.html load 1534394.html load 1547897.html load 1547898.html load 1556799.html -load 1579934.html load 1574544.html -load 1578916.html +pref(dom.mutation_events.enabled,true) load 1578916.html +pref(dom.mutation_events.enabled,true) load 1579934.html load 1581246.html load 1596516.html -load 1605741.html +pref(dom.mutation_events.enabled,true) load 1605741.html load 1613521.html load 1618906.html load 1623166.html @@ -106,9 +106,9 @@ load 1655539.html load 1659717.html load 1663725.html # throws load 1655508.html -load 1655988.html +pref(dom.mutation_events.enabled,true) load 1655988.html load 1677566.html -load 1691051.html +pref(dom.mutation_events.enabled,true) load 1691051.html load 1699866.html load 1701348.html -load 1707630.html +pref(dom.mutation_events.enabled,true) load 1707630.html diff --git a/testing/web-platform/meta/editing/crashtests/__dir__.ini b/testing/web-platform/meta/editing/crashtests/__dir__.ini new file mode 100644 index 000000000000..c94361a42f70 --- /dev/null +++ b/testing/web-platform/meta/editing/crashtests/__dir__.ini @@ -0,0 +1 @@ +prefs: [dom.mutation_events.enabled:true] diff --git a/testing/web-platform/tests/editing/other/delete-selection-with-null-range-crash.html b/testing/web-platform/tests/editing/crashtests/delete-selection-with-null-range.html similarity index 100% rename from testing/web-platform/tests/editing/other/delete-selection-with-null-range-crash.html rename to testing/web-platform/tests/editing/crashtests/delete-selection-with-null-range.html diff --git a/testing/web-platform/tests/editing/other/design-mode-textarea-crash.html b/testing/web-platform/tests/editing/crashtests/design-mode-textarea.html similarity index 100% rename from testing/web-platform/tests/editing/other/design-mode-textarea-crash.html rename to testing/web-platform/tests/editing/crashtests/design-mode-textarea.html diff --git a/testing/web-platform/tests/editing/run/empty-editable-crash.html b/testing/web-platform/tests/editing/crashtests/empty-editable.html similarity index 100% rename from testing/web-platform/tests/editing/run/empty-editable-crash.html rename to testing/web-platform/tests/editing/crashtests/empty-editable.html diff --git a/testing/web-platform/tests/editing/run/first-letter-crossing-engine-boundary-crash.html b/testing/web-platform/tests/editing/crashtests/first-letter-crossing-engine-boundary.html similarity index 74% rename from testing/web-platform/tests/editing/run/first-letter-crossing-engine-boundary-crash.html rename to testing/web-platform/tests/editing/crashtests/first-letter-crossing-engine-boundary.html index be6325fce489..ccea4365a69a 100644 --- a/testing/web-platform/tests/editing/run/first-letter-crossing-engine-boundary-crash.html +++ b/testing/web-platform/tests/editing/crashtests/first-letter-crossing-engine-boundary.html @@ -8,10 +8,7 @@
xx
- - diff --git a/testing/web-platform/tests/lint.ignore b/testing/web-platform/tests/lint.ignore index d9acac627aef..e62bc02738a7 100644 --- a/testing/web-platform/tests/lint.ignore +++ b/testing/web-platform/tests/lint.ignore @@ -693,7 +693,6 @@ TESTHARNESS-IN-OTHER-TYPE: css/css-text/white-space/pre-line-br-with-whitespace- TESTHARNESS-IN-OTHER-TYPE: css/css-text/white-space/pre-with-whitespace-crash.html TESTHARNESS-IN-OTHER-TYPE: css/css-writing-modes/bidi-inline-fragment-crash.html TESTHARNESS-IN-OTHER-TYPE: dom/svg-insert-crash.html -TESTHARNESS-IN-OTHER-TYPE: editing/run/first-letter-crossing-engine-boundary-crash.html TESTHARNESS-IN-OTHER-TYPE: html/canvas/element/manual/wide-gamut-canvas/imagedata-no-color-settings-crash.html TESTHARNESS-IN-OTHER-TYPE: html/semantics/embedded-content/the-object-element/block-object-with-ruby-crash.html TESTHARNESS-IN-OTHER-TYPE: html/semantics/forms/the-input-element/time-datalist-crash.html