Bug 1840210 - Rename mozac_ic_close to mozac_ic_cross_24

This commit is contained in:
Gabriel Luong
2023-06-24 00:57:01 -04:00
committed by mergify[bot]
parent 893f559560
commit edc8c27961
20 changed files with 21 additions and 23 deletions

View File

@@ -87,7 +87,7 @@ fun Tab(
onClick = { onClose.invoke(tab.id) }, onClick = { onClose.invoke(tab.id) },
) { ) {
Icon( Icon(
painter = painterResource(R.drawable.mozac_ic_close), painter = painterResource(R.drawable.mozac_ic_cross_24),
contentDescription = "close", contentDescription = "close",
tint = Color.White, tint = Color.White,
) )

View File

@@ -32,7 +32,7 @@
android:contentDescription="@string/mozac_feature_addons_remove" android:contentDescription="@string/mozac_feature_addons_remove"
android:layout_gravity="center_vertical" android:layout_gravity="center_vertical"
app:tint="@android:color/darker_gray" app:tint="@android:color/darker_gray"
app:srcCompat="@drawable/mozac_ic_close"/> app:srcCompat="@drawable/mozac_ic_cross_24"/>
<LinearLayout <LinearLayout
android:layout_width="wrap_content" android:layout_width="wrap_content"
@@ -58,4 +58,3 @@
</LinearLayout> </LinearLayout>

View File

@@ -14,7 +14,6 @@ import androidx.appcompat.content.res.AppCompatResources.getDrawable
import androidx.core.graphics.drawable.toDrawable import androidx.core.graphics.drawable.toDrawable
import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.cancel import kotlinx.coroutines.cancel
import kotlinx.coroutines.flow.collect
import kotlinx.coroutines.flow.mapNotNull import kotlinx.coroutines.flow.mapNotNull
import mozilla.components.browser.menu.BrowserMenuBuilder import mozilla.components.browser.menu.BrowserMenuBuilder
import mozilla.components.browser.menu.BrowserMenuItem import mozilla.components.browser.menu.BrowserMenuItem
@@ -165,7 +164,7 @@ class CustomTabsToolbarFeature(
@VisibleForTesting @VisibleForTesting
internal fun addCloseButton(tab: CustomTabSessionState, bitmap: Bitmap?) { internal fun addCloseButton(tab: CustomTabSessionState, bitmap: Bitmap?) {
val drawableIcon = bitmap?.toDrawable(context.resources) val drawableIcon = bitmap?.toDrawable(context.resources)
?: getDrawable(context, iconsR.drawable.mozac_ic_close)!!.mutate() ?: getDrawable(context, iconsR.drawable.mozac_ic_cross_24)!!.mutate()
drawableIcon.setTint(readableColor) drawableIcon.setTint(readableColor)

View File

@@ -54,7 +54,7 @@
android:contentDescription="@string/mozac_feature_downloads_button_close" android:contentDescription="@string/mozac_feature_downloads_button_close"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="parent"
app:srcCompat="@drawable/mozac_ic_close" app:srcCompat="@drawable/mozac_ic_cross_24"
app:tint="?android:attr/textColorPrimary" app:tint="?android:attr/textColorPrimary"
tools:textColor="#000000" /> tools:textColor="#000000" />

View File

@@ -52,7 +52,7 @@
android:scaleType="centerInside" android:scaleType="centerInside"
android:background="@null" android:background="@null"
android:contentDescription="@string/mozac_feature_downloads_button_close" android:contentDescription="@string/mozac_feature_downloads_button_close"
app:srcCompat="@drawable/mozac_ic_close" app:srcCompat="@drawable/mozac_ic_cross_24"
app:tint="?android:attr/textColorPrimary" app:tint="?android:attr/textColorPrimary"
tools:textColor="#000000" /> tools:textColor="#000000" />

View File

@@ -75,9 +75,9 @@
android:id="@+id/find_in_page_close_btn" android:id="@+id/find_in_page_close_btn"
style="@style/Mozac.Feature.FindInPage.Buttons" style="@style/Mozac.Feature.FindInPage.Buttons"
android:contentDescription="@string/mozac_feature_findindpage_dismiss" android:contentDescription="@string/mozac_feature_findindpage_dismiss"
app:srcCompat="@drawable/mozac_ic_close" app:srcCompat="@drawable/mozac_ic_cross_24"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@+id/find_in_page_next_btn" app:layout_constraintStart_toEndOf="@+id/find_in_page_next_btn"
app:layout_constraintTop_toTopOf="parent"/> app:layout_constraintTop_toTopOf="parent"/>
</merge> </merge>

View File

@@ -78,7 +78,7 @@ open class TabCounterMenu(
text = context.getString(R.string.mozac_close_tab), text = context.getString(R.string.mozac_close_tab),
start = DrawableMenuIcon( start = DrawableMenuIcon(
context, context,
iconsR.drawable.mozac_ic_close, iconsR.drawable.mozac_ic_cross_24,
tint = iconColor ?: getColor(context, R.color.mozac_ui_tabcounter_default_text), tint = iconColor ?: getColor(context, R.color.mozac_ui_tabcounter_default_text),
), ),
textStyle = TextStyle(), textStyle = TextStyle(),

View File

@@ -430,7 +430,7 @@ class ToolbarActivity : AppCompatActivity() {
binding.toolbar.url = "https://www.mozilla.org/en-US/firefox/mobile/" binding.toolbar.url = "https://www.mozilla.org/en-US/firefox/mobile/"
val drawableIcon = ContextCompat.getDrawable(this, iconsR.drawable.mozac_ic_close) val drawableIcon = ContextCompat.getDrawable(this, iconsR.drawable.mozac_ic_cross_24)
drawableIcon?.apply { drawableIcon?.apply {
setTint(0xFF20123a.toInt()) setTint(0xFF20123a.toInt())

View File

@@ -205,7 +205,7 @@ fun TabGridItem(
if (!multiSelectionEnabled) { if (!multiSelectionEnabled) {
Icon( Icon(
painter = painterResource(id = R.drawable.mozac_ic_close), painter = painterResource(id = R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(id = R.string.close_tab), contentDescription = stringResource(id = R.string.close_tab),
tint = FirefoxTheme.colors.iconPrimary, tint = FirefoxTheme.colors.iconPrimary,
modifier = Modifier modifier = Modifier

View File

@@ -168,7 +168,7 @@ fun TabListItem(
.testTag(TabsTrayTestTag.tabItemClose), .testTag(TabsTrayTestTag.tabItemClose),
) { ) {
Icon( Icon(
painter = painterResource(id = R.drawable.mozac_ic_close), painter = painterResource(id = R.drawable.mozac_ic_cross_24),
contentDescription = stringResource( contentDescription = stringResource(
id = R.string.close_tab_title, id = R.string.close_tab_title,
tab.content.title, tab.content.title,

View File

@@ -104,7 +104,7 @@ fun OnboardingPage(
modifier = Modifier.align(Alignment.End), modifier = Modifier.align(Alignment.End),
) { ) {
Icon( Icon(
painter = painterResource(id = R.drawable.mozac_ic_close), painter = painterResource(id = R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(R.string.onboarding_home_content_description_close_button), contentDescription = stringResource(R.string.onboarding_home_content_description_close_button),
tint = FirefoxTheme.colors.iconPrimary, tint = FirefoxTheme.colors.iconPrimary,
) )

View File

@@ -89,7 +89,7 @@ fun CookieBannerReEngagementDialogCompose(
onClick = onCloseButtonClicked, onClick = onCloseButtonClicked,
) { ) {
Icon( Icon(
painter = painterResource(R.drawable.mozac_ic_close), painter = painterResource(R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(R.string.content_description_close_button), contentDescription = stringResource(R.string.content_description_close_button),
tint = FirefoxTheme.colors.iconPrimary, tint = FirefoxTheme.colors.iconPrimary,
) )

View File

@@ -114,7 +114,7 @@ fun InactiveTabsList(
faviconPainter = faviconPainter, faviconPainter = faviconPainter,
onClick = { onTabClick(tab) }, onClick = { onTabClick(tab) },
url = tabUrl, url = tabUrl,
iconPainter = painterResource(R.drawable.mozac_ic_close), iconPainter = painterResource(R.drawable.mozac_ic_cross_24),
iconDescription = stringResource(R.string.content_description_close_button), iconDescription = stringResource(R.string.content_description_close_button),
onIconClick = { onTabCloseClick(tab) }, onIconClick = { onTabCloseClick(tab) },
) )

View File

@@ -61,7 +61,7 @@ fun WallpaperOnboarding(
horizontalAlignment = Alignment.CenterHorizontally, horizontalAlignment = Alignment.CenterHorizontally,
) { ) {
Icon( Icon(
painter = painterResource(id = R.drawable.mozac_ic_close), painter = painterResource(id = R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(id = R.string.close_tab), contentDescription = stringResource(id = R.string.close_tab),
tint = FirefoxTheme.colors.iconPrimary, tint = FirefoxTheme.colors.iconPrimary,
modifier = Modifier modifier = Modifier

View File

@@ -56,7 +56,7 @@
android:scaleType="centerInside" android:scaleType="centerInside"
android:background="@null" android:background="@null"
android:contentDescription="@string/mozac_feature_downloads_button_close" android:contentDescription="@string/mozac_feature_downloads_button_close"
app:srcCompat="@drawable/mozac_ic_close" app:srcCompat="@drawable/mozac_ic_cross_24"
app:tint="?android:attr/textColorPrimary" app:tint="?android:attr/textColorPrimary"
tools:textColor="#000000" /> tools:textColor="#000000" />

View File

@@ -135,7 +135,7 @@ private fun CloseButton(onCloseButtonClick: () -> Unit) {
onClick = onCloseButtonClick, onClick = onCloseButtonClick,
) { ) {
Icon( Icon(
painter = painterResource(R.drawable.mozac_ic_close), painter = painterResource(R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(R.string.onboarding_close_button_content_description), contentDescription = stringResource(R.string.onboarding_close_button_content_description),
tint = focusColors.closeIcon, tint = focusColors.closeIcon,
) )

View File

@@ -146,7 +146,7 @@ private fun CloseButton(onCloseButtonClick: () -> Unit) {
onClick = onCloseButtonClick, onClick = onCloseButtonClick,
) { ) {
Icon( Icon(
painter = painterResource(R.drawable.mozac_ic_close), painter = painterResource(R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(R.string.onboarding_close_button_content_description), contentDescription = stringResource(R.string.onboarding_close_button_content_description),
tint = focusColors.closeIcon, tint = focusColors.closeIcon,
) )

View File

@@ -193,7 +193,7 @@ private fun CloseButton(
.padding(10.dp), .padding(10.dp),
) { ) {
Icon( Icon(
painter = painterResource(R.drawable.mozac_ic_close), painter = painterResource(R.drawable.mozac_ic_cross_24),
contentDescription = stringResource(id = R.string.promote_search_widget_dialog_content_description), contentDescription = stringResource(id = R.string.promote_search_widget_dialog_content_description),
tint = focusColors.closeIcon, tint = focusColors.closeIcon,
) )

View File

@@ -39,9 +39,9 @@
android:layout_centerVertical="true" android:layout_centerVertical="true"
android:contentDescription="@string/close_tab" android:contentDescription="@string/close_tab"
android:scaleType="center" android:scaleType="center"
android:src="@drawable/mozac_ic_close" android:src="@drawable/mozac_ic_cross_24"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent" app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/session_title" app:layout_constraintStart_toEndOf="@id/session_title"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout> </androidx.constraintlayout.widget.ConstraintLayout>