corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1583052 - Remove an optimization introduced in bug 1555946 which is not sound. r=smaug

Browse Source 
Tasks dispatched from RunInStableState() can be cancelled if there's a load in
between, so this is not sound.

See nsSyncSection::IsCancelled().

This is the only patch in this bug that is worth uplifting IMO.

Differential Revision: https://phabricator.services.mozilla.com/D46773
This commit is contained in:
Emilio Cobos Álvarez
2019-09-23 13:08:53 +00:00
parent e3bb9f4a19
commit ed0a614e97
3 changed files with 62 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
dom/html/HTMLMediaElement.cpp
View File

@@ -4452,21 +4452,25 @@ void HTMLMediaElement::UnbindFromTree(bool aNullParent) {
MOZ_ASSERT(IsHidden());
NotifyDecoderActivityChanges();
// https://html.spec.whatwg.org/#playing-the-media-resource:remove-an-element-from-a-document
//
// Dispatch a task to run once we're in a stable state which ensures we're
// paused if we're no longer in a document. Note we set a flag here to
// ensure we don't dispatch redundant tasks.
if (!mDispatchedTaskToPauseIfNotInDocument) {
mDispatchedTaskToPauseIfNotInDocument = true;
nsCOMPtr<nsIRunnable> task = NS_NewRunnableFunction(
"dom::HTMLMediaElement::UnbindFromTree",
[self = RefPtr<HTMLMediaElement>(this)]() {
self->mDispatchedTaskToPauseIfNotInDocument = false;
if (!self->IsInComposedDoc()) {
self->Pause();
}
});
RunInStableState(task);
}
// paused if we're no longer in a document. Note that we need to dispatch this
// even if there are other tasks in flight for this because these can be
// cancelled if there's a new load.
//
// FIXME(emilio): Per that spec section, we should only do this if we used to
// be connected, though other browsers match our current behavior...
//
// Also, https://github.com/whatwg/html/issues/4928
nsCOMPtr<nsIRunnable> task = NS_NewRunnableFunction(
"dom::HTMLMediaElement::UnbindFromTree",
[self = RefPtr<HTMLMediaElement>(this)]() {
if (!self->IsInComposedDoc()) {
self->Pause();
}
});
RunInStableState(task);
}
/* static */