corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1709217 - Part 6: Get rid of NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE; r=smaug

Browse Source 
Depends on D114185

Differential Revision: https://phabricator.services.mozilla.com/D114186
This commit is contained in:
Edgar Chen
2021-05-11 19:38:46 +00:00
parent dbe4fb5605
commit e9343c93ea
4 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
devtools/server/actors/network-monitor/utils/network-utils.js
View File

@@ -310,7 +310,6 @@ const ErrorCodes = {
NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT: 0x80530403, NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT: 0x80530403,
NS_ERROR_DOM_IMAGE_INVALID_REQUEST: 0x80530404, NS_ERROR_DOM_IMAGE_INVALID_REQUEST: 0x80530404,
NS_ERROR_DOM_IMAGE_BROKEN: 0x80530405, NS_ERROR_DOM_IMAGE_BROKEN: 0x80530405,
NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE: 0x8053040b,
NS_ERROR_DOM_CORP_FAILED: 0x8053040c, NS_ERROR_DOM_CORP_FAILED: 0x8053040c,
NS_SUCCESS_DOM_NO_OPERATION: 0x530001, NS_SUCCESS_DOM_NO_OPERATION: 0x530001,
NS_SUCCESS_DOM_SCRIPT_EVALUATION_THREW: 0x530002, NS_SUCCESS_DOM_SCRIPT_EVALUATION_THREW: 0x530002,

3
dom/base/Document.cpp
View File

@@ -5578,7 +5578,8 @@ void Document::QueryCommandValue(const nsAString& aHTMLCommandName,
// Only allow on HTML documents. // Only allow on HTML documents.
if (!IsHTMLOrXHTML()) { if (!IsHTMLOrXHTML()) {
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE); aRv.ThrowInvalidStateError(
"queryCommandValue is only supported on HTML documents");
return; return;
} }
// Otherwise, don't throw exception for compatibility with Chrome. // Otherwise, don't throw exception for compatibility with Chrome.

3
dom/base/domerr.msg
View File

@@ -159,6 +159,3 @@ DOM4_MSG_DEF(InvalidAccessError, "synchronous XMLHttpRequests do not support tim
DOM4_MSG_DEF(EncodingError, "Node bound to inactive document.", NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT) DOM4_MSG_DEF(EncodingError, "Node bound to inactive document.", NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT)
DOM4_MSG_DEF(EncodingError, "Invalid image request.", NS_ERROR_DOM_IMAGE_INVALID_REQUEST) DOM4_MSG_DEF(EncodingError, "Invalid image request.", NS_ERROR_DOM_IMAGE_INVALID_REQUEST)
DOM4_MSG_DEF(EncodingError, "Invalid encoded image data.", NS_ERROR_DOM_IMAGE_BROKEN) DOM4_MSG_DEF(EncodingError, "Invalid encoded image data.", NS_ERROR_DOM_IMAGE_BROKEN)
/* Editing command errors. */
DOM4_MSG_DEF(InvalidStateError, "queryCommandValue is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE)

3
xpcom/base/ErrorList.py
View File

@@ -755,9 +755,6 @@ with modules["DOM"]:
errors["NS_ERROR_DOM_IMAGE_INVALID_REQUEST"] = FAILURE(1028) errors["NS_ERROR_DOM_IMAGE_INVALID_REQUEST"] = FAILURE(1028)
errors["NS_ERROR_DOM_IMAGE_BROKEN"] = FAILURE(1029) errors["NS_ERROR_DOM_IMAGE_BROKEN"] = FAILURE(1029)
# Editing command errors.
errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE"] = FAILURE(1035)
# Used to indicate that a resource with the Cross-Origin-Resource-Policy # Used to indicate that a resource with the Cross-Origin-Resource-Policy
# response header set failed the origin check. # response header set failed the origin check.
# https://fetch.spec.whatwg.org/#cross-origin-resource-policy-header # https://fetch.spec.whatwg.org/#cross-origin-resource-policy-header