corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1857400 - Use CMAKE_MSVC_RUNTIME_LIBRARY instead of LLVM_USE_CRT_RELEASE. r=firefox-build-system-reviewers,sergesanspaille

Browse Source 
The latter was deprecated in
c6bd873403
and removed more recently in
618e5d2c2d

Fortunately, the former works with LLVM 17, so we don't need to
special case, we can use the same as for trunk.

Differential Revision: https://phabricator.services.mozilla.com/D190248
This commit is contained in:
Mike Hommey
2023-10-07 07:15:29 +00:00
parent b6b7eaf255
commit e7dfef952a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
build/build-clang/build-clang.py
View File

@@ -268,7 +268,7 @@ def build_one_stage(
cmake_args += ["-DLLVM_ENABLE_TERMINFO=OFF"]
if is_windows(target):
cmake_args.insert(-1, "-DLLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON")
cmake_args.insert(-1, "-DLLVM_USE_CRT_RELEASE=MT")
cmake_args.insert(-1, "-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded")
if is_cross_compile(target):
cmake_args += [
f"-DCMAKE_TOOLCHAIN_FILE={src_dir}/cmake/platforms/WinMsvc.cmake",