corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1143629 - Contacts import incorrectly displays all forms of plural strings. r=mikedeboer, a=lmandel

Browse Source
This commit is contained in:
Mark Banner
2015-03-16 14:51:11 +00:00
parent d128b80951
commit e6a68dbaf9
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
browser/components/loop/content/js/contacts.js
View File

@@ -455,6 +455,7 @@ loop.contacts = (function(_, mozL10n) {
return; return;
} }
this.props.notifications.successL10n("import_contacts_success_message", { this.props.notifications.successL10n("import_contacts_success_message", {
num: stats.total,
total: stats.total total: stats.total
}); });
}); });

1
browser/components/loop/content/js/contacts.jsx
View File

@@ -455,6 +455,7 @@ loop.contacts = (function(_, mozL10n) {
return; return;
} }
this.props.notifications.successL10n("import_contacts_success_message", { this.props.notifications.successL10n("import_contacts_success_message", {
num: stats.total,
total: stats.total total: stats.total
}); });
}); });

3
browser/components/loop/test/desktop-local/contacts_test.js
View File

@@ -277,7 +277,8 @@ describe("loop.contacts", function() {
sinon.assert.calledWithExactly( sinon.assert.calledWithExactly(
notifications.successL10n, notifications.successL10n,
"import_contacts_success_message", "import_contacts_success_message",
{total: 42}); // Num is for the plural selection.
{num: 42, total: 42});
}); });
it("should notify the end user from any encountered error", function() { it("should notify the end user from any encountered error", function() {