corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the extra AddRef to nsHistoryLayoutState. r=pollmann, bug #16496

Browse Source
This commit is contained in:
radha@netscape.com
1999-11-01 21:47:54 +00:00
parent bd013b412b
commit e4fc33276d
2 changed files with 2 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
docshell/base/nsWebShell.cpp
View File

@@ -2300,8 +2300,7 @@ nsWebShell::LoadURL(const PRUnichar *aURLSpec,
* session History, it will be set to the cached history object by
* session History.
*/
if (aHistoryState)
SetHistoryState(aHistoryState);
SetHistoryState(aHistoryState);
/*
* Set mURL to spec so that session history can get
@@ -2729,11 +2728,6 @@ nsWebShell::GetHistoryState(nsISupports** aLayoutHistoryState)
rv = docv->GetPresShell(*getter_AddRefs(shell));
if (NS_SUCCEEDED(rv)) {
rv = shell->GetHistoryState((nsILayoutHistoryState**) aLayoutHistoryState);
/* The following line was added by mistake in one of the previous checkins. It
* causes a leak of nsHistorylayoutState. But removing it causes a crash.
* Eric Pollmann(pollmann@netscape.com) is investigating it. Bug # 16496
*/
NS_ADDREF(*aLayoutHistoryState);
}
}
}