Fixing bug 781310. Change nsPluginHost::GetInst() to return already_AddRefed<nsPluginHost> to make it harder to write leaky code. r=jschoenick@mozilla.com

2013-03-20 11:29:00 -07:00
parent e365bb449d
commit e41a6bd869
7 changed files with 15 additions and 23 deletions
--- a/dom/plugins/base/nsNPAPIPluginInstance.cpp
+++ b/dom/plugins/base/nsNPAPIPluginInstance.cpp
@@ -1786,8 +1786,7 @@ nsNPAPIPluginInstance::CheckJavaC2PJSObjectQuirk(uint16_t paramCount,
    return;
  }

-  nsRefPtr<nsPluginHost> pluginHost =
-    already_AddRefed<nsPluginHost>(nsPluginHost::GetInst());
+  nsRefPtr<nsPluginHost> pluginHost = nsPluginHost::GetInst();
  if (!pluginHost) {
    return;
  }