corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing bug 781310. Change nsPluginHost::GetInst() to return already_AddRefed<nsPluginHost> to make it harder to write leaky code. r=jschoenick@mozilla.com

Browse Source
This commit is contained in:
Johnny Stenback
2013-03-20 11:29:00 -07:00
parent e365bb449d
commit e41a6bd869
7 changed files with 15 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/plugins/base/nsNPAPIPlugin.cpp
View File

@@ -249,7 +249,7 @@ void
nsNPAPIPlugin::PluginCrashed(const nsAString& pluginDumpID,
const nsAString& browserDumpID)
{
nsRefPtr<nsPluginHost> host = dont_AddRef(nsPluginHost::GetInst());
nsRefPtr<nsPluginHost> host = nsPluginHost::GetInst();
host->PluginCrashed(this, pluginDumpID, browserDumpID);
}
@@ -888,7 +888,7 @@ _geturl(NPP npp, const char* relativeURL, const char* target)
const char *name = nullptr;
nsRefPtr<nsPluginHost> host = dont_AddRef(nsPluginHost::GetInst());
nsRefPtr<nsPluginHost> host = nsPluginHost::GetInst();
host->GetPluginName(inst, &name);
if (name && strstr(name, "Adobe") && strstr(name, "Acrobat")) {
@@ -1623,7 +1623,7 @@ _getproperty(NPP npp, NPObject* npobj, NPIdentifier property,
nsNPAPIPlugin* plugin = inst->GetPlugin();
if (!plugin)
return false;
nsRefPtr<nsPluginHost> host = dont_AddRef(nsPluginHost::GetInst());
nsRefPtr<nsPluginHost> host = nsPluginHost::GetInst();
nsPluginTag* pluginTag = host->TagForPlugin(plugin);
if (!pluginTag->mIsJavaPlugin)
return true;