Bug 1782271 - Remove Warp async and generator options r=bthrall
Differential Revision: https://phabricator.services.mozilla.com/D153231
This commit is contained in:
@@ -1,4 +1,4 @@
|
|||||||
// |jit-test| --ion-offthread-compile=off; --ion-full-warmup-threshold=0; --ion-gvn=off; --warp-async; --baseline-eager
|
// |jit-test| --ion-offthread-compile=off; --ion-full-warmup-threshold=0; --ion-gvn=off; --baseline-eager
|
||||||
//
|
//
|
||||||
// Bug 1683306 - Assertion failure: !genObj->hasStackStorage() || genObj->isStackStorageEmpty(), at vm/GeneratorObject.cpp:144
|
// Bug 1683306 - Assertion failure: !genObj->hasStackStorage() || genObj->isStackStorageEmpty(), at vm/GeneratorObject.cpp:144
|
||||||
|
|
||||||
|
|||||||
@@ -1,8 +1,7 @@
|
|||||||
// |jit-test| slow; --ion-offthread-compile=off; --warp-async
|
// |jit-test| slow; --ion-offthread-compile=off;
|
||||||
//
|
//
|
||||||
// Bug 1683309: Assertion failure: [barrier verifier] Unmarked edge: JS Object 0xebbb6d1dee0 'object slot' edge to JS Object 0xebbb6d29f60, at gc/Verifier.cpp:392
|
// Bug 1683309: Assertion failure: [barrier verifier] Unmarked edge: JS Object 0xebbb6d1dee0 'object slot' edge to JS Object 0xebbb6d29f60, at gc/Verifier.cpp:392
|
||||||
//
|
|
||||||
// The following testcase crashes on mozilla-central revision 20201217-2ab4142f19bc (debug build, run with --ion-offthread-compile=off --warp-async):
|
|
||||||
|
|
||||||
if (helperThreadCount() > 0) {
|
if (helperThreadCount() > 0) {
|
||||||
evalInWorker(`
|
evalInWorker(`
|
||||||
|
|||||||
@@ -1,6 +1,5 @@
|
|||||||
// |jit-test| --ion-offthread-compile=off; --ion-full-warmup-threshold=0; --warp-async; --baseline-eager; skip-if: !this.hasOwnProperty("ReadableStream")
|
// |jit-test| --ion-offthread-compile=off; --ion-full-warmup-threshold=0; --baseline-eager; skip-if: !this.hasOwnProperty("ReadableStream")
|
||||||
//
|
|
||||||
// The following testcase crashes on mozilla-central revision 20201219-3262affdccf6 (debug build, run with --fuzzing-safe --ion-offthread-compile=off --ion-full-warmup-threshold=0 --warp-async --baseline-eager):
|
|
||||||
gczeal(9, 8);
|
gczeal(9, 8);
|
||||||
function s() { }
|
function s() { }
|
||||||
new ReadableStream({
|
new ReadableStream({
|
||||||
|
|||||||
@@ -1690,17 +1690,7 @@ static bool CanIonCompileOrInlineScript(JSScript* script, const char** reason) {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (script->isGenerator() && !JitOptions.warpGenerator) {
|
|
||||||
*reason = "generator script";
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (script->isAsync()) {
|
if (script->isAsync()) {
|
||||||
if (!JitOptions.warpAsync) {
|
|
||||||
*reason = "async script";
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (script->isModule()) {
|
if (script->isModule()) {
|
||||||
*reason = "async module";
|
*reason = "async module";
|
||||||
return false;
|
return false;
|
||||||
|
|||||||
@@ -129,12 +129,6 @@ DefaultJitOptions::DefaultJitOptions() {
|
|||||||
// Whether the IonMonkey JIT is enabled.
|
// Whether the IonMonkey JIT is enabled.
|
||||||
SET_DEFAULT(ion, true);
|
SET_DEFAULT(ion, true);
|
||||||
|
|
||||||
// Warp compile Async functions
|
|
||||||
SET_DEFAULT(warpAsync, true);
|
|
||||||
|
|
||||||
// Warp compile Generator functions
|
|
||||||
SET_DEFAULT(warpGenerator, true);
|
|
||||||
|
|
||||||
// Whether the IonMonkey and Baseline JITs are enabled for Trusted Principals.
|
// Whether the IonMonkey and Baseline JITs are enabled for Trusted Principals.
|
||||||
// (Ignored if ion or baselineJit is set to true.)
|
// (Ignored if ion or baselineJit is set to true.)
|
||||||
SET_DEFAULT(jitForTrustedPrincipals, false);
|
SET_DEFAULT(jitForTrustedPrincipals, false);
|
||||||
|
|||||||
@@ -63,8 +63,6 @@ struct DefaultJitOptions {
|
|||||||
bool baselineInterpreter;
|
bool baselineInterpreter;
|
||||||
bool baselineJit;
|
bool baselineJit;
|
||||||
bool ion;
|
bool ion;
|
||||||
bool warpAsync;
|
|
||||||
bool warpGenerator;
|
|
||||||
bool jitForTrustedPrincipals;
|
bool jitForTrustedPrincipals;
|
||||||
bool nativeRegExp;
|
bool nativeRegExp;
|
||||||
bool forceInlineCaches;
|
bool forceInlineCaches;
|
||||||
|
|||||||
@@ -48,10 +48,6 @@
|
|||||||
--spectre-mitigations=on
|
--spectre-mitigations=on
|
||||||
--more-compartments
|
--more-compartments
|
||||||
--fast-warmup
|
--fast-warmup
|
||||||
--warp-generator
|
|
||||||
--warp-async
|
|
||||||
--no-warp-generator
|
|
||||||
--no-warp-async
|
|
||||||
--large-arraybuffers
|
--large-arraybuffers
|
||||||
--no-jit-backend
|
--no-jit-backend
|
||||||
--enable-watchtower
|
--enable-watchtower
|
||||||
|
|||||||
@@ -11359,22 +11359,6 @@ static bool SetContextOptions(JSContext* cx, const OptionParser& op) {
|
|||||||
jit::JitOptions.baselineJit = false;
|
jit::JitOptions.baselineJit = false;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (op.getBoolOption("no-warp-async")) {
|
|
||||||
jit::JitOptions.warpAsync = false;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (op.getBoolOption("no-warp-generator")) {
|
|
||||||
jit::JitOptions.warpGenerator = false;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (op.getBoolOption("warp-async")) {
|
|
||||||
jit::JitOptions.warpAsync = true;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (op.getBoolOption("warp-generator")) {
|
|
||||||
jit::JitOptions.warpGenerator = true;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (op.getBoolOption("no-ion")) {
|
if (op.getBoolOption("no-ion")) {
|
||||||
jit::JitOptions.ion = false;
|
jit::JitOptions.ion = false;
|
||||||
}
|
}
|
||||||
@@ -12224,13 +12208,6 @@ int main(int argc, char** argv) {
|
|||||||
!op.addBoolOption('\0', "baseline",
|
!op.addBoolOption('\0', "baseline",
|
||||||
"Enable baseline compiler (default)") ||
|
"Enable baseline compiler (default)") ||
|
||||||
!op.addBoolOption('\0', "no-baseline", "Disable baseline compiler") ||
|
!op.addBoolOption('\0', "no-baseline", "Disable baseline compiler") ||
|
||||||
!op.addBoolOption('\0', "no-warp-async",
|
|
||||||
"Don't Warp compile Async Functions") ||
|
|
||||||
!op.addBoolOption('\0', "no-warp-generator",
|
|
||||||
"Warp compile Generator Functions") ||
|
|
||||||
!op.addBoolOption('\0', "warp-async", "Warp compile Async Functions") ||
|
|
||||||
!op.addBoolOption('\0', "warp-generator",
|
|
||||||
"Don't Warp compile Generator Functions") ||
|
|
||||||
!op.addBoolOption('\0', "baseline-eager",
|
!op.addBoolOption('\0', "baseline-eager",
|
||||||
"Always baseline-compile methods") ||
|
"Always baseline-compile methods") ||
|
||||||
!op.addIntOption(
|
!op.addIntOption(
|
||||||
|
|||||||
Reference in New Issue
Block a user