corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1553705 - Use a cheaper to compute state key for parser inserted form controls. r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D32259
This commit is contained in:
Cameron McCormack
2019-06-26 21:44:11 +00:00
parent a7dd303c43
commit e0c2d268cb
13 changed files with 199 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
dom/html/HTMLInputElement.cpp
View File

@@ -939,7 +939,7 @@ void HTMLInputElement::Shutdown() {
HTMLInputElement::HTMLInputElement(
already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo,
FromParser aFromParser, FromClone aFromClone)
: nsGenericHTMLFormElementWithState(std::move(aNodeInfo),
: nsGenericHTMLFormElementWithState(std::move(aNodeInfo), aFromParser,
kInputDefaultType->value),
mAutocompleteAttrState(nsContentUtils::eAutocompleteAttrState_Unknown),
mAutocompleteInfoState(nsContentUtils::eAutocompleteAttrState_Unknown),
@@ -5894,11 +5894,8 @@ void HTMLInputElement::DoneCreatingElement() {
// Restore state as needed. Note that disabled state applies to all control
// types.
//
bool restoredCheckedState = false;
if (!mInhibitRestoration) {
GenerateStateKey();
restoredCheckedState = RestoreFormControlState();
}
GenerateStateKey();
bool restoredCheckedState = !mInhibitRestoration && RestoreFormControlState();
//
// If restore does not occur, we initialize .checked using the CHECKED