corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1562257 part 4. Fix style mapping of hspace and vspace attributes to match the spec. r=mccr8

Browse Source 
Per spec, "hspace" and "vspace" are parsed as dimension attributes and are
supported on the following elements: embed, iframe, img, object,
<input type="image">, marquee.  Except no one implements this for iframe.
https://github.com/whatwg/html/issues/4742 tracks the spec changing accordingly.

As far as hspace/vpace on <table> go, Safari supports them in both quirks and
standards mode, while Chrome doesn't support them in either mode.  The HTML spec
doesn't have them supported at all, and neither does the quirks mode spec, so
I'm removing the quirks-only support we had to align with the specs and Chrome.

Differential Revision: https://phabricator.services.mozilla.com/D36375
This commit is contained in:
Boris Zbarsky
2019-06-28 23:51:43 +00:00
parent 5f5845a805
commit e0623a2b67
11 changed files with 196 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
dom/html/HTMLTableElement.cpp
View File

@@ -832,9 +832,6 @@ bool HTMLTableElement::ParseAttribute(int32_t aNamespaceID, nsAtom* aAttribute,
aAttribute == nsGkAtoms::bordercolor) {
return aResult.ParseColor(aValue);
}
if (aAttribute == nsGkAtoms::hspace || aAttribute == nsGkAtoms::vspace) {
return aResult.ParseIntWithBounds(aValue, 0);
}
}
return nsGenericHTMLElement::ParseBackgroundAttribute(
@@ -855,8 +852,6 @@ void HTMLTableElement::MapAttributesIntoRule(
// which *element* it's matching (style rules should not stop matching
// when the display type is changed).
nsCompatibility mode = aDecls.Document()->GetCompatibilityMode();
// cellspacing
const nsAttrValue* value = aAttributes->GetAttr(nsGkAtoms::cellspacing);
if (value && value->Type() == nsAttrValue::eInteger &&
@@ -875,28 +870,6 @@ void HTMLTableElement::MapAttributesIntoRule(
}
}
// hspace is mapped into left and right margin,
// vspace is mapped into top and bottom margins
// - *** Quirks Mode only ***
if (eCompatibility_NavQuirks == mode) {
value = aAttributes->GetAttr(nsGkAtoms::hspace);
if (value && value->Type() == nsAttrValue::eInteger) {
aDecls.SetPixelValueIfUnset(eCSSProperty_margin_left,
(float)value->GetIntegerValue());
aDecls.SetPixelValueIfUnset(eCSSProperty_margin_right,
(float)value->GetIntegerValue());
}
value = aAttributes->GetAttr(nsGkAtoms::vspace);
if (value && value->Type() == nsAttrValue::eInteger) {
aDecls.SetPixelValueIfUnset(eCSSProperty_margin_top,
(float)value->GetIntegerValue());
aDecls.SetPixelValueIfUnset(eCSSProperty_margin_bottom,
(float)value->GetIntegerValue());
}
}
// bordercolor
value = aAttributes->GetAttr(nsGkAtoms::bordercolor);
nscolor color;
@@ -937,8 +910,7 @@ HTMLTableElement::IsAttributeMapped(const nsAtom* aAttribute) const {
static const MappedAttributeEntry attributes[] = {
{nsGkAtoms::cellpadding}, {nsGkAtoms::cellspacing},
{nsGkAtoms::border}, {nsGkAtoms::width},
{nsGkAtoms::height}, {nsGkAtoms::hspace},
{nsGkAtoms::vspace},
{nsGkAtoms::height},
{nsGkAtoms::bordercolor},