corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 834766 - GC: Fix some more rooting issues found by static analysis r=sphink

Browse Source
This commit is contained in:
Jon Coppeard
2013-01-25 17:48:07 +00:00
parent c49098bd02
commit df4fd4168d
4 changed files with 28 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
js/src/jsweakmap.cpp
View File

@@ -276,7 +276,7 @@ WeakMap_set_impl(JSContext *cx, CallArgs args)
if (!key)
return false;
Value value = (args.length() > 1) ? args[1] : UndefinedValue();
RootedValue value(cx, (args.length() > 1) ? args[1] : UndefinedValue());
Rooted<JSObject*> thisObj(cx, &args.thisv().toObject());
ObjectValueMap *map = GetObjectMap(thisObj);
@@ -322,8 +322,9 @@ WeakMap_set(JSContext *cx, unsigned argc, Value *vp)
}
JS_FRIEND_API(JSBool)
JS_NondeterministicGetWeakMapKeys(JSContext *cx, JSObject *obj, JSObject **ret)
JS_NondeterministicGetWeakMapKeys(JSContext *cx, JSObject *objArg, JSObject **ret)
{
RootedObject obj(cx, objArg);
obj = UnwrapObject(obj);
if (!obj || !obj->isWeakMap()) {
*ret = NULL;