Backed out 3 changesets (bug 1919114) for causing nogpu related reftests failures. CLOSED TREE

Backed out changeset 9e75159e3f24 (bug 1919114)
Backed out changeset 9fbb4bf4480d (bug 1919114)
Backed out changeset 9c9e6df18d35 (bug 1919114)

gfx/layers/apz/test/reftest/reftest.list

@@ -41,8 +41,8 @@ skip-if(useDrawSnapshot) == frame-reconstruction-scroll-clamping.html frame-reco
 
 # Test that position:fixed and position:sticky elements are attached to the
 # layout viewport.
-skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) fuzzy(0-1,0-24) == pinch-zoom-position-fixed.html pinch-zoom-position-fixed-ref.html
+skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) == pinch-zoom-position-fixed.html pinch-zoom-position-fixed-ref.html
-skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) fuzzy(0-1,0-24) == pinch-zoom-position-sticky.html pinch-zoom-position-sticky-ref.html
+skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) == pinch-zoom-position-sticky.html pinch-zoom-position-sticky-ref.html
 
 pref(apz.allow_zooming,true) == iframe-zoomed.html iframe-zoomed-ref.html
 pref(apz.allow_zooming,true) == scaled-iframe-zoomed.html scaled-iframe-zoomed-ref.html

ipc/glue/UtilityAudioDecoderChild.cpp

@@ -16,7 +16,6 @@
 #  include "mozilla/gfx/gfxVars.h"
 #  include "mozilla/ipc/UtilityProcessManager.h"
 #  include "mozilla/layers/PVideoBridge.h"
-#  include "mozilla/layers/VideoBridgeParent.h"
 #  include "mozilla/layers/VideoBridgeUtils.h"
 #endif
 
@@ -163,9 +162,6 @@ void UtilityAudioDecoderChild::OnCompositorUnexpectedShutdown() {
 
 bool UtilityAudioDecoderChild::CreateVideoBridge() {
   MOZ_ASSERT(NS_IsMainThread());
-  ipc::Endpoint<layers::PVideoBridgeParent> parentPipe;
-  ipc::Endpoint<layers::PVideoBridgeChild> childPipe;
-
   MOZ_ASSERT(mSandbox == SandboxingKind::MF_MEDIA_ENGINE_CDM);
 
   // Creating or already created, avoiding reinit a bridge.
@@ -174,26 +170,30 @@ bool UtilityAudioDecoderChild::CreateVideoBridge() {
   }
   mHasCreatedVideoBridge = State::Creating;
 
-  gfx::GPUProcessManager* gpuManager = gfx::GPUProcessManager::Get();
-  ipc::EndpointProcInfo gpuProcessInfo = gpuManager
-                                             ? gpuManager->GPUEndpointProcInfo()
-                                             : ipc::EndpointProcInfo::Invalid();
-
   // Build content device data first; this ensure that the GPU process is fully
   // ready.
   gfx::ContentDeviceData contentDeviceData;
   gfxPlatform::GetPlatform()->BuildContentDeviceData(&contentDeviceData);
 
+  gfx::GPUProcessManager* gpuManager = gfx::GPUProcessManager::Get();
+  if (!gpuManager) {
+    NS_WARNING("Failed to get a gpu mananger!");
+    return false;
+  }
+
   // The child end is the producer of video frames; the parent end is the
   // consumer.
   EndpointProcInfo childInfo = UtilityProcessManager::GetSingleton()
                                    ->GetProcessParent(mSandbox)
                                    ->OtherEndpointProcInfo();
-  EndpointProcInfo parentInfo =
+  EndpointProcInfo parentInfo = gpuManager->GPUEndpointProcInfo();
-      gpuProcessInfo != ipc::EndpointProcInfo::Invalid()
+  if (parentInfo == EndpointProcInfo::Invalid()) {
-          ? gpuProcessInfo
+    NS_WARNING("GPU process Id is invald!");
-          : ipc::EndpointProcInfo::Current();
+    return false;
+  }
 
+  ipc::Endpoint<layers::PVideoBridgeParent> parentPipe;
+  ipc::Endpoint<layers::PVideoBridgeChild> childPipe;
   nsresult rv = layers::PVideoBridge::CreateEndpoints(parentInfo, childInfo,
                                                       &parentPipe, &childPipe);
   if (NS_FAILED(rv)) {
@@ -201,16 +201,9 @@ bool UtilityAudioDecoderChild::CreateVideoBridge() {
     return false;
   }
 
-  if (gpuProcessInfo != ipc::EndpointProcInfo::Invalid()) {
   gpuManager->InitVideoBridge(
       std::move(parentPipe),
       layers::VideoBridgeSource::MFMediaEngineCDMProcess);
-  } else {
-    layers::VideoBridgeParent::Open(
-        std::move(parentPipe),
-        layers::VideoBridgeSource::MFMediaEngineCDMProcess);
-  }
-
   SendInitVideoBridge(std::move(childPipe), contentDeviceData);
   return true;
 }

layout/reftests/bugs/reftest.list

@@ -315,7 +315,7 @@ fuzzy(0-1,0-133) == 273681-1.html 273681-1-ref.html
 == 283686-2.html 283686-2-ref.html
 == 283686-3.html about:blank
 == 289384-1.xhtml 289384-ref.xhtml
-random-if(winWidget) fuzzy(0-25,0-2751) fails-if(useDrawSnapshot) HTTP == 289480.html#top 289480-ref.html # basically-verbatim acid2 test, HTTP for a 404 page -- bug 578114 for the winWidget failures
+random-if(winWidget) fuzzy(0-25,0-2148) fails-if(useDrawSnapshot) HTTP == 289480.html#top 289480-ref.html # basically-verbatim acid2 test, HTTP for a 404 page -- bug 578114 for the winWidget failures
 == 290129-1.html 290129-1-ref.html
 == 291078-1.html 291078-1-ref.html
 == 291078-2.html 291078-2-ref.html
@@ -1164,7 +1164,7 @@ fuzzy(0-4,0-361) == 449519-1.html 449519-1-ref.html
 fails-if(Android) == 455826-1.html 455826-1-ref.html
 == chrome://reftest/content/bugs/456147.xhtml 456147-ref.html
 fuzzy(24-110,110-800) == 456219-1a.html 456219-1-ref.html # bug 1128229
-fuzzy(24-110,107-3200) == 456219-1b.html 456219-1-ref.html # bug 1128229
+fuzzy(24-110,107-1251) == 456219-1b.html 456219-1-ref.html # bug 1128229
 fuzzy(24-110,107-3800) == 456219-1c.html 456219-1-ref.html # bug 1128229
 fuzzy(0-10,0-8) == 456219-2.html 456219-2-ref.html
 == 456330-1.gif 456330-1-ref.png
@@ -2009,7 +2009,7 @@ needs-focus != 1377447-1.html 1377447-2.html
 fuzzy(0-129,0-48) == 1406179.html 1406179-ref.html
 == 1406183-1.html 1406183-1-ref.html
 == 1410028.html 1410028-ref.html
-fuzzy-if((!gtkWidget&&!geckoview&&!swgl&&!(isCoverageBuild&&winWidget))||useDrawSnapshot,0-2,0-17500) skip-if(winWidget&&isCoverageBuild) == 1412375.html 1412375-ref.html # Skip WinCCov: Bug 1740155
+fuzzy-if((!gtkWidget&&!geckoview&&!swgl&&!(isCoverageBuild&&winWidget))||useDrawSnapshot,1-2,17300-17500) skip-if(winWidget&&isCoverageBuild) == 1412375.html 1412375-ref.html # Skip WinCCov: Bug 1740155
 # Note: The test below has a large fuzz, because svg text chooses
 # scale-dependent font metrics. Without the fix the test fails in the range
 # 246-255,3237-25110, which overlaps the fuzz range, but would still catch
@@ -2018,7 +2018,7 @@ fuzzy(0-255,0-6025) == 1415987-1.html 1415987-1-ref.html
 == 1419820-1.html 1419820-1-ref.html
 == 1420946-1.html 1420946-1-ref.html
 == 1422393.html 1422393-ref.html
-skip-if(winWidget&&isCoverageBuild) fuzzy(0-1,0-4) == 1424177.html 1424177-ref.html
+skip-if(winWidget&&isCoverageBuild) == 1424177.html 1424177-ref.html
 == 1424680.html 1424680-ref.html
 == 1424798-1.html 1424798-ref.html
 fuzzy-if(swgl,0-1,0-31430) == 1425243-1.html 1425243-1-ref.html

layout/reftests/css-blending/reftest.list

@@ -23,17 +23,17 @@ random-if(useDrawSnapshot) == background-blending-list-repeat.html background-bl
 == background-blending-color-burn.html background-blending-color-burn-ref.svg
 == background-blending-color-dodge.html background-blending-color-dodge-ref.svg
 # need to investigate why these tests are fuzzy - first suspect is a possible color space conversion on some platforms; same for mix-blend-mode tests
-fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(winWidget,0-1,0-9600) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-color.html background-blending-color-ref.svg
+fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(winWidget,0-1,0-8000) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-color.html background-blending-color-ref.svg
 == background-blending-darken.html background-blending-darken-ref.svg
 == background-blending-difference.html background-blending-difference-ref.svg
 fuzzy(0-1,0-1600) == background-blending-exclusion.html background-blending-exclusion-ref.svg
 fuzzy-if(cocoaWidget||winWidget||swgl,0-1,0-1600) == background-blending-hard-light.html background-blending-hard-light-ref.svg
 fuzzy-if(winWidget,0-1,0-9600) fuzzy-if(!winWidget,0-1,0-11200) fuzzy-if(!geckoview,1-1,9600-11240) == background-blending-hue.html background-blending-hue-ref.svg
 == background-blending-lighten.html background-blending-lighten-ref.svg
-fuzzy-if(winWidget,0-1,0-9600) fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-luminosity.html background-blending-luminosity-ref.svg
+fuzzy-if(winWidget,0-1,0-8000) fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-luminosity.html background-blending-luminosity-ref.svg
 fuzzy(0-1,0-1600) == background-blending-multiply.html background-blending-multiply-ref.svg
 == background-blending-normal.html background-blending-normal-ref.svg
-fuzzy(0-1,0-1600) == background-blending-overlay.html background-blending-overlay-ref.svg
+fuzzy-if(!winWidget,0-1,0-1600) == background-blending-overlay.html background-blending-overlay-ref.svg
 fuzzy-if(winWidget,0-1,0-3200) fuzzy-if(!winWidget,0-2,0-12800) == background-blending-saturation.html background-blending-saturation-ref.svg
 fuzzy(0-1,0-1600) == background-blending-screen.html background-blending-screen-ref.svg
 fuzzy(0-10,0-4800) == background-blending-soft-light.html background-blending-soft-light-ref.svg

layout/reftests/image-element/reftest.list

@@ -12,7 +12,7 @@ fuzzy-if(winWidget,47-132,47-54) == element-paint-simple.html element-paint-simp
 == element-paint-recursion.html element-paint-recursion-ref.html
 == element-paint-continuation.html element-paint-continuation-ref.html
 == element-paint-transform-01.html element-paint-transform-01-ref.html
-random-if(winWidget&&!gfxSVGFE) fuzzy-if(!useDrawSnapshot,255-255,39-42) fuzzy-if(gfxSVGFE,0-255,0-1984) == element-paint-transform-02.html element-paint-transform-02-ref.html # bug 587133
+random-if(winWidget&&!gfxSVGFE) fuzzy-if(!useDrawSnapshot,255-255,39-42) fuzzy-if(gfxSVGFE,0-255,0-1983) == element-paint-transform-02.html element-paint-transform-02-ref.html # bug 587133
 == element-paint-background-size-01.html element-paint-background-size-01-ref.html
 == element-paint-background-size-02.html element-paint-background-size-02-ref.html
 fuzzy(0-255,0-4) == element-paint-transform-repeated.html element-paint-transform-repeated-ref.html # Bug 1475907

layout/reftests/svg/as-image/reftest.list

@@ -96,7 +96,7 @@ fuzzy-if(winWidget,0-1,0-10000) test-pref(svg.context-properties.content.enabled
 == img-simple-2.html  lime100x100-ref.html
 fuzzy(0-255,0-350) fuzzy-if(geckoview,0-255,0-4063) == img-simple-3.html img-simple-3-ref.html #Bug 1564891, bug 1574154
 == img-simple-4.html  lime100x100-ref.html
-fuzzy(0-255,0-90) fuzzy-if(geckoview,0-255,0-1286) == img-simple-5.html img-simple-5-ref.html
+fuzzy(0-255,0-90) fuzzy-if(geckoview,0-255,0-1268) == img-simple-5.html img-simple-5-ref.html
 == img-simple-6.html  lime100x100-ref.html
 fuzzy(0-255,0-27) == img-simple-7.html img-simple-7-ref.html
 

layout/reftests/svg/filters/reftest.list

@@ -114,7 +114,7 @@ fuzzy(0-1,0-400) == feDisplacementMap-alpha-01.svg pass.svg
 fuzzy(0-2,0-500) == feDisplacementMap-colour-01.svg feDisplacementMap-colour-01-ref.svg
 == feDisplacementMap-scale-01.svg pass.svg
 
-fuzzy-if(winWidget,0-2,0-25) fuzzy-if(Android13&&aarch64,6-6,4549-4549) fuzzy-if(!useDrawSnapshot,55-98,14033-16467) fuzzy-if(gfxSVGFEDropShadow&&!gfxSVGFEOffset,97-98,21500-22951) fuzzy-if(gfxSVGFEOffset,0-6,0-1000000) == feDropShadow-01.svg feDropShadow-01-ref.svg
+fuzzy-if(winWidget,0-2,0-25)  fuzzy-if(Android13&&aarch64,6-6,4549-4549) fuzzy-if(!useDrawSnapshot,55-98,14033-16467) fuzzy-if(gfxSVGFEDropShadow&&!gfxSVGFEOffset,97-98,21500-22951) fuzzy-if(gfxSVGFEOffset,0-2,0-1000000) == feDropShadow-01.svg feDropShadow-01-ref.svg
 
 == feFlood-color-01.svg pass.svg
 

layout/reftests/svg/reftest.list

@@ -367,7 +367,7 @@ fuzzy-if(winWidget,0-16,0-5) == paint-order-01.svg paint-order-01-ref.svg
 == paint-order-02.svg paint-order-02-ref.svg
 == paint-order-03.svg paint-order-03-ref.svg
 
-fuzzy(0-54,0-80) == path-01.svg path-01-ref.svg
+fuzzy(0-54,0-77) == path-01.svg path-01-ref.svg
 == path-02.svg pass.svg
 == path-04.svg pass.svg
 == path-05.svg pass.svg

layout/reftests/transform/reftest.list

@@ -161,7 +161,7 @@ test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animati
 test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-4.html partial-prerender-expansion-ref.html
 # This reftest doesn't fail on WebRender, this reftest fails only if there is a jank mechanism and the mechanism does inproperly handle position:fixed scroll target
 test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-5.html partial-prerender-translate-5-ref.html
-skip-if(useDrawSnapshot) test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-250,0-1250) fuzzy-if(Android,0-255,0-9900) random-if(gtkWidget&&isDebugBuild) random-if(useDrawSnapshot) == partial-prerender-translate-6.html partial-prerender-translate-6-ref.html
+skip-if(useDrawSnapshot) test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-46,0-1250) fuzzy-if(Android,0-255,0-9900) random-if(gtkWidget&&isDebugBuild) random-if(useDrawSnapshot) == partial-prerender-translate-6.html partial-prerender-translate-6-ref.html
 test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-4,0-1200) == partial-prerender-translate-7.html partial-prerender-translate-2-ref.html
 # This reftest doesn't fail on WebRender, this reftest fails only if there is a jank mechanism and the mechanism doesn't properly clip transform in iframes.
 test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-8.html partial-prerender-translate-8-ref.html

taskcluster/config.yml

@@ -79,8 +79,6 @@ treeherder:
         'M-nofis-cf': 'Mochitests confirm failure without fission enabled'
         'M-nofis-ship': "Mochitests without fission and with SHIP (session history in parent) enabled (Android-specific)"
         'M-nofis-ship-cf': "Mochitests confirm failure: no fission + with SHIP (session history in parent) on (Android-only)"
-        'M-nogpu': 'Mochitests without GPU process enabled'
-        'M-nogpu-cf': 'Mochitests confirm failure without GPU process enabled'
         'M-spi': 'Mochitests with socket process'
         'M-spi-cf': 'Mochitests confirm failure with socket process'
         'M-spi-nofis': 'Mochitests with socket process without fission enabled'
@@ -125,8 +123,6 @@ treeherder:
         'R-nofis-cf': 'Reftests confirm failure without fission enabled'
         'R-nofis-ship': 'Reftests without fission and with SHIP (session history in parent) enabled (Android specific)'
         'R-nofis-ship-cf': 'Reftests confirm failure: no fission + with SHIP (session history in parent) on (Android-only)'
-        'R-nogpu': 'Reftests without GPU process enabled'
-        'R-nogpu-cf': 'Reftests confirm failure without GPU process enabled'
         'R-swr': 'Reftests with software webrender enabled'
         'R-swr-cf': 'Reftests confirm failure with software webrender enabled'
         'R-swr-nofis': 'Reftests with software webrender enabled without fission enabled'

taskcluster/kinds/test/mochitest.yml

@@ -713,7 +713,6 @@ mochitest-media:
     variants:
         - media-gpu
         - no-fission
-        - no-gpu-process
         - socketprocess+no-fission
         - socketprocess
         - webrender-sw+no-fission

taskcluster/kinds/test/reftest.yml

@@ -180,7 +180,6 @@ reftest:
         - draw-snapshot
         - geckoview-no-fission-ship
         - no-fission
-        - no-gpu-process
         - webrender-dcomp-disabled
         - webrender-dcomp-present
         - webrender-dcomp-overlays
@@ -262,7 +261,6 @@ reftest-qr:
     test-manifest-loader: null  # don't load tests in the taskgraph
     variants:
         - no-fission
-        - no-gpu-process
         - webrender-sw+no-fission
     run-without-variant: false
     run-on-projects:
@@ -272,7 +270,6 @@ reftest-qr:
                     android-hw-p5-13-0-android-aarch64-qr/debug: built-projects
                     default: []
             no-fission: built-projects
-            no-gpu-process: built-projects
     max-run-time: 2400
     mozharness:
         chunked: true

taskcluster/kinds/test/variants.yml

@@ -398,25 +398,6 @@ media-gpu:
             extra-options:
                 - "--setpref=media.hardware-video-decoding.force-enabled=true"
 
-no-gpu-process:
-    description: "{description} without a dedicated GPU process"
-    component: "Core::Graphics"
-    expiration: "2025-03-01"
-    suffix: "nogpu"
-    mozinfo: "nogpu"
-    when:
-        $eval: '
-                    "windows" in task["test-platform"]
-                    || "android" in task["test-platform"]
-                '
-    replace:
-        virtualization: virtual
-    merge:
-        mozharness:
-            extra-options:
-                - "--setpref=layers.gpu-process.enabled=false"
-                - "--setpref=layers.gpu-process.force-enabled=false"
-
 msix:
     description: "{description} from msix packages"
     component: "Firefox:Installer"