corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Activity

Bug 1501608 - Remove the ELEMENT_SLOT in the ScriptSourceObject and instead use a callback function to return the script element based on the value of the privateValue in the SSO. r=jonco,smaug

Browse Source 
We can reduce the size of the SSO by removing the element slot entirely, and instead retrieve the element through a callback function.  The callback will take in the value in the private slot of the SSO, which is either a LoadedScript* (from the browser) or a JSObject* (from the shell).  In addition, this removes the requirement of having a script dom element ready when parsing a JS script which can open up new opportunities for performance.

Differential Revision: https://phabricator.services.mozilla.com/D70417
This commit is contained in:
Denis Palmeiro
2020-05-12 19:28:15 +00:00
parent cd5742f9a5
commit dec5889516
22 changed files with 245 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dom/script/ScriptLoadHandler.cpp
View File

@@ -209,7 +209,7 @@ bool ScriptLoadHandler::TrySetDecoder(nsIIncrementalStreamLoader* aLoader,
// request.
nsAutoString hintCharset;
if (!mRequest->IsPreload()) {
mRequest->Element()->GetScriptCharset(hintCharset);
mRequest->GetScriptElement()->GetScriptCharset(hintCharset);
} else {
nsTArray<ScriptLoader::PreloadInfo>::index_type i =
mScriptLoader->mPreloads.IndexOf(
@@ -279,7 +279,7 @@ nsresult ScriptLoadHandler::EnsureKnownDataType(
if (mRequest->IsLoadingSource()) {
mRequest->SetTextSource();
TRACE_FOR_TEST(mRequest->Element(), "scriptloader_load_source");
TRACE_FOR_TEST(mRequest->GetScriptElement(), "scriptloader_load_source");
return NS_OK;
}
@@ -289,7 +289,8 @@ nsresult ScriptLoadHandler::EnsureKnownDataType(
cic->GetAlternativeDataType(altDataType);
if (altDataType.Equals(nsContentUtils::JSBytecodeMimeType())) {
mRequest->SetBytecode();
TRACE_FOR_TEST(mRequest->Element(), "scriptloader_load_bytecode");
TRACE_FOR_TEST(mRequest->GetScriptElement(),
"scriptloader_load_bytecode");
return NS_OK;
}
MOZ_ASSERT(altDataType.IsEmpty());
@@ -303,7 +304,8 @@ nsresult ScriptLoadHandler::EnsureKnownDataType(
if (mimeType.LowerCaseEqualsASCII(APPLICATION_JAVASCRIPT_BINAST)) {
if (mRequest->ShouldAcceptBinASTEncoding()) {
mRequest->SetBinASTSource();
TRACE_FOR_TEST(mRequest->Element(), "scriptloader_load_source");
TRACE_FOR_TEST(mRequest->GetScriptElement(),
"scriptloader_load_source");
return NS_OK;
}
@@ -317,7 +319,7 @@ nsresult ScriptLoadHandler::EnsureKnownDataType(
}
mRequest->SetTextSource();
TRACE_FOR_TEST(mRequest->Element(), "scriptloader_load_source");
TRACE_FOR_TEST(mRequest->GetScriptElement(), "scriptloader_load_source");
MOZ_ASSERT(!mRequest->IsUnknownDataType());
MOZ_ASSERT(mRequest->IsLoading());