corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1949599 - Remove animated onboarding callouts for Tab Groups r=omc-reviewers,jprickett

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D239181
This commit is contained in:
Emily McMinn
2025-02-26 17:02:18 +00:00
parent 8ab002aa2c
commit de64394a0c
1 changed files with 0 additions and 151 deletions
Download Patch File Download Diff File Expand all files Collapse all files

151
browser/components/asrouter/modules/FeatureCalloutMessages.sys.mjs
View File

@@ -285,157 +285,6 @@ const MESSAGES = () => {
skip_in_tests:
"not tested in automation and might pop up unexpectedly during review checker tests",
},
{
id: "TAB_GROUP_ONBOARDING_CALLOUT",
template: "feature_callout",
groups: ["cfr"],
content: {
id: "TAB_GROUP_ONBOARDING_CALLOUT",
template: "multistage",
backdrop: "transparent",
transitions: false,
screens: [
{
id: "TAB_GROUP_ONBOARDING_CALLOUT_HORIZONTAL",
anchors: [
{
selector:
"#tabbrowser-tabs:not([overflow]) .tab-content[selected]:not([pinned])",
panel_position: {
anchor_attachment: "bottomcenter",
callout_attachment: "topright",
},
},
{
selector: "#tabbrowser-tabs",
panel_position: {
anchor_attachment: "bottomcenter",
callout_attachment: "topright",
},
},
],
content: {
position: "callout",
width: "333px",
padding: 16,
logo: {
imageURL:
"chrome://browser/content/asrouter/assets/tabgroups/hort-animated-light.svg",
darkModeImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/hort-animated-dark.svg",
reducedMotionImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/hort-static-light.svg",
darkModeReducedMotionImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/hort-static-dark.svg",
height: "172px",
width: "300px",
},
title: {
string_id: "tab-groups-onboarding-feature-callout-title",
},
subtitle: {
string_id: "tab-groups-onboarding-feature-callout-subtitle",
},
dismiss_button: {
action: {
dismiss: true,
},
size: "small",
marginInline: "0 20px",
marginBlock: "20px 0",
},
},
},
],
},
targeting:
"tabsClosedCount >= 1 && currentTabsOpen >= 8 && ('browser.tabs.groups.enabled' | preferenceValue) && (!'sidebar.verticalTabs' | preferenceValue) && currentTabGroups == 0 && savedTabGroups == 0",
trigger: {
id: "nthTabClosed",
},
frequency: {
lifetime: 1,
},
skip_in_tests:
"not tested in automation and might pop up unexpectedly during review checker tests",
},
{
id: "TAB_GROUP_ONBOARDING_CALLOUT",
template: "feature_callout",
groups: ["cfr"],
content: {
id: "TAB_GROUP_ONBOARDING_CALLOUT",
template: "multistage",
backdrop: "transparent",
transitions: false,
screens: [
{
id: "TAB_GROUP_ONBOARDING_CALLOUT_VERTICAL",
anchors: [
{
selector:
"#tabbrowser-tabs:not([overflow]) .tab-content[selected]:not([pinned])",
panel_position: {
anchor_attachment: "rightcenter",
callout_attachment: "topleft",
},
},
{
selector: "#tabbrowser-tabs",
panel_position: {
anchor_attachment: "rightcenter",
callout_attachment: "topleft",
},
},
],
content: {
position: "callout",
width: "333px",
padding: 16,
logo: {
imageURL:
"chrome://browser/content/asrouter/assets/tabgroups/vert-animated-light.svg",
darkModeImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/vert-animated-dark.svg",
reducedMotionImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/vert-static-light.svg",
darkModeReducedMotionImageURL:
"chrome://browser/content/asrouter/assets/tabgroups/vert-static-dark.svg",
height: "172px",
width: "300px",
},
title: {
string_id: "tab-groups-onboarding-feature-callout-title",
},
subtitle: {
string_id: "tab-groups-onboarding-feature-callout-subtitle",
},
dismiss_button: {
action: {
dismiss: true,
},
size: "small",
marginInline: "0 20px",
marginBlock: "20px 0",
},
},
},
],
},
targeting:
"tabsClosedCount >= 1 && currentTabsOpen >= 8 && ('browser.tabs.groups.enabled' | preferenceValue) && ('sidebar.revamp' | preferenceValue) && ('sidebar.verticalTabs' | preferenceValue) && currentTabGroups == 0 && savedTabGroups == 0",
trigger: {
id: "nthTabClosed",
},
frequency: {
lifetime: 1,
},
skip_in_tests:
"not tested in automation and might pop up unexpectedly during review checker tests",
},
// Appears the first time a user uses the "save and close" action on a tab group,
// anchored to the alltabs-button. Will only show if at least an hour has passed
// since the CREATE_TAB_GROUP callout showed.
{
id: "SAVE_TAB_GROUP_ONBOARDING_CALLOUT",
template: "feature_callout",