corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1702670 - Fix some orange by keeping the UpdateState() call from SetValueChanged unconditionally.

Browse Source 
Because the ui-validity bits depend on it.

MANUAL PUSH: Mochitest failures on a CLOSED TREE
This commit is contained in:
Emilio Cobos Álvarez
2021-04-08 19:03:37 +02:00
parent d43e77dcc2
commit de32461a5f
4 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
dom/html/HTMLTextAreaElement.cpp
View File

@@ -320,28 +320,28 @@ nsresult HTMLTextAreaElement::SetValueChanged(bool aValueChanged) {
}
if (mValueChanged != previousValue) {
ValueChangedOrLastValueChangeWasInteractiveChanged();
UpdateTooLongValidityState();
UpdateTooShortValidityState();
// We need to do this unconditionally because the validity ui bits depend on
// this.
UpdateState(true);
}
return NS_OK;
}
void HTMLTextAreaElement::ValueChangedOrLastValueChangeWasInteractiveChanged() {
const bool wasValid = IsValid();
UpdateTooLongValidityState();
UpdateTooShortValidityState();
if (wasValid != IsValid()) {
UpdateState(true);
}
}
void HTMLTextAreaElement::SetLastValueChangeWasInteractive(
bool aWasInteractive) {
if (aWasInteractive == mLastValueChangeWasInteractive) {
return;
}
mLastValueChangeWasInteractive = aWasInteractive;
ValueChangedOrLastValueChangeWasInteractiveChanged();
const bool wasValid = IsValid();
UpdateTooLongValidityState();
UpdateTooShortValidityState();
if (wasValid != IsValid()) {
UpdateState(true);
}
}
void HTMLTextAreaElement::GetDefaultValue(nsAString& aDefaultValue,