corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1103368, part 5 - Make Class::getProperty and setProperty nullable instead of needing stub functions. Never store stub functions in JSPropertyDescriptors. r=bhackett.

Browse Source
This commit is contained in:
Jason Orendorff
2014-11-22 12:23:39 -06:00
parent 19d34d3db0
commit ddde8586c6
89 changed files with 534 additions and 734 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
js/ipc/JavaScriptShared.cpp
View File

@@ -554,10 +554,8 @@ JavaScriptShared::fromDescriptor(JSContext *cx, Handle<JSPropertyDescriptor> des
return false;
out->getter() = objVar;
} else {
if (desc.getter() == JS_PropertyStub)
out->getter() = 0;
else
out->getter() = UnknownPropertyOp;
MOZ_ASSERT(desc.getter() != JS_PropertyStub);
out->getter() = UnknownPropertyOp;
}
if (!desc.setter()) {
@@ -569,10 +567,8 @@ JavaScriptShared::fromDescriptor(JSContext *cx, Handle<JSPropertyDescriptor> des
return false;
out->setter() = objVar;
} else {
if (desc.setter() == JS_StrictPropertyStub)
out->setter() = 0;
else
out->setter() = UnknownPropertyOp;
MOZ_ASSERT(desc.setter() != JS_StrictPropertyStub);
out->setter() = UnknownPropertyOp;
}
return true;