corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1625304 - Remove INTERNAL_LOAD_FLAGS_IS_USER_TRIGGERED. r=mattwoodrow

Browse Source 
It's unused (modulo assertions that mask it off), and I want to add something
similar for bug 1528305, so this avoids some confusion.

Differential Revision: https://phabricator.services.mozilla.com/D68456
This commit is contained in:
Emilio Cobos Álvarez
2020-03-26 22:39:16 +00:00
parent a1b1465d11
commit dd0a18c9a4
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
docshell/base/nsDocShell.cpp
View File

@@ -8364,9 +8364,8 @@ nsresult nsDocShell::PerformRetargeting(nsDocShellLoadState* aLoadState,
MOZ_ASSERT(aLoadState->PrincipalToInherit() ==
aLoadState->TriggeringPrincipal());
MOZ_ASSERT(
(aLoadState->LoadFlags() & ~INTERNAL_LOAD_FLAGS_IS_USER_TRIGGERED) ==
INTERNAL_LOAD_FLAGS_NO_OPENER ||
(aLoadState->LoadFlags() & ~INTERNAL_LOAD_FLAGS_IS_USER_TRIGGERED) ==
aLoadState->LoadFlags() == INTERNAL_LOAD_FLAGS_NO_OPENER ||
aLoadState->LoadFlags() ==
(INTERNAL_LOAD_FLAGS_NO_OPENER |
INTERNAL_LOAD_FLAGS_DONT_SEND_REFERRER));
MOZ_ASSERT(!aLoadState->PostDataStream());
@@ -12383,10 +12382,6 @@ nsresult nsDocShell::OnLinkClickSync(
GetIsExecutingOnLoadHandler(&inOnLoadHandler);
uint32_t loadType = inOnLoadHandler ? LOAD_NORMAL_REPLACE : LOAD_LINK;
if (aIsUserTriggered) {
flags |= INTERNAL_LOAD_FLAGS_IS_USER_TRIGGERED;
}
nsCOMPtr<nsIReferrerInfo> referrerInfo = new ReferrerInfo();
if (isElementAnchorOrArea) {
referrerInfo->InitWithNode(aContent);