From dc9a3fb47b28d8079c900564103c9577447e6ed8 Mon Sep 17 00:00:00 2001 From: Yazan Al Macki Date: Fri, 6 Dec 2024 18:35:07 +0000 Subject: [PATCH] Bug 1933158 - Prevent mask icons from being stored. r=mak Differential Revision: https://phabricator.services.mozilla.com/D230809 --- browser/actors/LinkHandlerChild.sys.mjs | 4 ++-- browser/base/content/test/favicons/file_mask_icon.html | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/browser/actors/LinkHandlerChild.sys.mjs b/browser/actors/LinkHandlerChild.sys.mjs index 95c86b2d0f12..c39244d79bde 100644 --- a/browser/actors/LinkHandlerChild.sys.mjs +++ b/browser/actors/LinkHandlerChild.sys.mjs @@ -112,8 +112,8 @@ export class LinkHandlerChild extends JSWindowActorChild { isRichIcon = true; // fall through case "icon": - if (iconAdded || link.hasAttribute("mask")) { - // Masked icons are not supported yet. + if (iconAdded || link.hasAttribute("color") || rel.includes("mask")) { + // TODO (Bug 1337397): Add support for mask-icon favicons. break; } diff --git a/browser/base/content/test/favicons/file_mask_icon.html b/browser/base/content/test/favicons/file_mask_icon.html index 5bcd9e694ffe..1a2c67b1a7f6 100644 --- a/browser/base/content/test/favicons/file_mask_icon.html +++ b/browser/base/content/test/favicons/file_mask_icon.html @@ -3,8 +3,8 @@ Mask Icon - - + +