Bug 1116473 - [1.1] Handle AndroidSurfaceTexture mapping in thread-safe class. r=snorp

gfx/gl/AndroidSurfaceTexture.cpp

@@ -6,7 +6,6 @@
 
 #ifdef MOZ_WIDGET_ANDROID
 
-#include <set>
 #include <map>
 #include <android/log.h>
 #include "AndroidSurfaceTexture.h"
@@ -27,9 +26,57 @@ using namespace mozilla::widget::sdk;
 namespace mozilla {
 namespace gl {
 
-// UGH
+// Maintains a mapping between AndroidSurfaceTexture instances and their
-static std::map<int, AndroidSurfaceTexture*> sInstances;
+// unique numerical IDs. [thread-safe]
-static int sNextID = 0;
+class InstanceMap
+{
+  typedef AndroidSurfaceTexture* InstancePtr;
+  typedef std::map<int, InstancePtr> MapType;
+
+public:
+  InstanceMap()
+    : mNextId(0)
+    , mMonitor("AndroidSurfaceTexture::InstanceMap::mMonitor")
+  {}
+
+  int Add(InstancePtr aInstance)
+  {
+    MonitorAutoLock lock(mMonitor);
+    mInstances.insert({++mNextId, aInstance});
+    return mNextId;
+  }
+
+  void Remove(int aId)
+  {
+    MonitorAutoLock lock(mMonitor);
+    mInstances.erase(aId);
+  }
+
+  InstancePtr Get(int aId) const
+  {
+    MonitorAutoLock lock(mMonitor);
+
+    auto it = mInstances.find(aId);
+    if (it == mInstances.end()) {
+      return nullptr;
+    }
+    return it->second;
+  }
+
+private:
+  MapType mInstances;
+  int mNextId;
+
+  mutable Monitor mMonitor;
+};
+
+static InstanceMap sInstances;
+
+AndroidSurfaceTexture*
+AndroidSurfaceTexture::Find(int aId)
+{
+  return sInstances.Get(aId);
+}
 
 static bool
 IsSTSupported()
@@ -59,19 +106,6 @@ AndroidSurfaceTexture::Create(GLContext* aContext, GLuint aTexture)
   return st.forget();
 }
 
-AndroidSurfaceTexture*
-AndroidSurfaceTexture::Find(int id)
-{
-  std::map<int, AndroidSurfaceTexture*>::iterator it;
-
-  it = sInstances.find(id);
-  if (it == sInstances.end())
-    return nullptr;
-
-  return it->second;
-}
-
-
 nsresult
 AndroidSurfaceTexture::Attach(GLContext* aContext, PRIntervalTime aTimeout)
 {
@@ -170,8 +204,7 @@ AndroidSurfaceTexture::Init(GLContext* aContext, GLuint aTexture)
                                                          mSurface.Get());
   MOZ_ASSERT(mNativeWindow, "Failed to create native window from surface");
 
-  mID = ++sNextID;
+  mID = sInstances.Add(this);
-  sInstances.insert(std::pair<int, AndroidSurfaceTexture*>(mID, this));
 
   return true;
 }
@@ -180,15 +213,15 @@ AndroidSurfaceTexture::AndroidSurfaceTexture()
   : mTexture(0)
   , mSurfaceTexture()
   , mSurface()
-  , mMonitor("AndroidSurfaceTexture::mContextMonitor")
   , mAttachedContext(nullptr)
   , mCanDetach(false)
+  , mMonitor("AndroidSurfaceTexture::mContextMonitor")
 {
 }
 
 AndroidSurfaceTexture::~AndroidSurfaceTexture()
 {
-  sInstances.erase(mID);
+  sInstances.Remove(mID);
 
   mFrameAvailableCallback = nullptr;
 

gfx/gl/AndroidSurfaceTexture.h

@@ -44,7 +44,7 @@ public:
   // Android Jelly Bean.
   static already_AddRefed<AndroidSurfaceTexture> Create();
 
-  static AndroidSurfaceTexture* Find(int id);
+  static AndroidSurfaceTexture* Find(int aId);
 
   // If we are on Jelly Bean, the SurfaceTexture can be detached and reattached
   // to allow consumption from different GLContexts. It is recommended to only