Bug 1953005 - Adjust browser_all_files_referenced, browser_parsable_css and allowed-dupes for built-in newtab addon case. r=baku

This also updates the addon-jar.mn script to remove the static chrome / resource registrations,
as this is taken care of in resource-mapping.js, and causes interesting test failures in CI
when included (specifically, if the manifest is refreshed after resource-mapping has run).

Differential Revision: https://phabricator.services.mozilla.com/D241463
This commit is contained in:
Mike Conley
2025-03-14 20:18:50 +00:00
parent 573226f5c9
commit db199bd880
4 changed files with 12 additions and 3 deletions

View File

@@ -113,6 +113,7 @@ var gExceptionPaths = [
"resource://builtin-addons/formautofill/",
// The newtab add-on
"resource://builtin-addons/newtab/",
"resource://newtab/",
"chrome://newtab/",
];

View File

@@ -550,7 +550,7 @@ add_task(async function checkAllTheCSS() {
if (imageHost == "browser") {
for (let ref of references) {
let refHost = ref.split("/")[2];
if (!["newtab", "browser"].includes(refHost)) {
if (!["builtin-addons", "newtab", "browser"].includes(refHost)) {
ok(
false,
"browser file " + image + " referenced outside browser in " + ref

View File

@@ -3,8 +3,6 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
browser.jar:
% resource newtab %builtin-addons contentaccessible=yes
% content newtab %content/builtin-addons contentaccessible=yes
builtin-addons/newtab/manifest.json (./manifest.json)
builtin-addons/newtab/webext-glue/background.js (./webext-glue/background.js)
builtin-addons/newtab/webext-glue/schema.json (./webext-glue/schema.json)

View File

@@ -95,8 +95,18 @@ browser/defaults/settings/main/search-config-icons/fed4f021-ff3e-942a-010e-afa43
# Bug 1946262 - De-Duplicate by moving glyph svg icons in a shared location
browser/chrome/browser/content/browser/asrouter/assets/glyph-mail-16.svg
#ifdef BROWSER_NEWTAB_AS_ADDON
browser/chrome/browser/builtin-addons/newtab/data/data/content/assets/glyph-mail-16.svg
#else
browser/chrome/browser/content/newtab/data/content/assets/glyph-mail-16.svg
#endif
# Bug 1946597 - Move glyph-webextension-16.svg in browser/themes/shared/icons
browser/chrome/browser/content/activity-stream/data/content/assets/glyph-webextension-16.svg
browser/chrome/browser/content/newtab/data/content/assets/glyph-webextension-16.svg
#ifdef BROWSER_NEWTAB_AS_ADDON
# Bug 1946564 - Remove once newtab's schema.json changes.
browser/features/formautofill@mozilla.org/schema.json
browser/chrome/browser/builtin-addons/newtab/webext-glue/schema.json
#endif