corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed 2 minor space leaks having to do with temporary structs allocated

Browse Source 
to handle colspans
This commit is contained in:
buster
1998-07-13 18:11:12 +00:00
parent f51318b16c
commit d9e15c6a11
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
layout/tables/BasicTableLayoutStrategy.cpp
View File

@@ -482,7 +482,16 @@ PRBool BasicTableLayoutStrategy::AssignFixedColumnWidths(nsIPresContext* aPresCo
if (nsnull!=spanList)
delete spanList;
if (nsnull!=colSpanList)
{
PRInt32 colSpanListCount = colSpanList->Count();
for (PRInt32 i=0; i<colSpanListCount; i++)
{
ColSpanStruct * colSpanInfo = (ColSpanStruct *)(colSpanList->ElementAt(i));
if (nsnull!=colSpanInfo)
delete colSpanInfo;
}
delete colSpanList;
}
return PR_TRUE;
}
@@ -1281,8 +1290,8 @@ PRBool BasicTableLayoutStrategy::BalanceColumnsConstrained( nsIPresContext* aPre
printf (" after cell %d, minColWidth=%d maxColWidth=%d effColWidth[%d]=%d,%d\n",
rowIndex, minColWidth, maxColWidth,
colIndex, effectiveMaxColumnWidths[colIndex], effectiveMaxColumnWidths[colIndex]);
if (1<colSpan)
{
if ((1<colSpan) && (cellFrame->GetColIndex()==colIndex))
{ // if this cell spans columns and we are processing the column that owns the cell
// add the cell to our list of spanners
SpanInfo *spanInfo = new SpanInfo(colSpan-1, cellMinWidth, cellDesiredWidth);
if (nsnull==spanList)
@@ -1466,7 +1475,10 @@ PRBool BasicTableLayoutStrategy::BalanceColumnsConstrained( nsIPresContext* aPre
if (nsnull!=effectiveMaxColumnWidths)
delete [] effectiveMaxColumnWidths;
if (nsnull!=spanList)
{
NS_ASSERTION(0==spanList->Count(), "space leak, span list not empty");
delete spanList;
}
return result;
}