corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1888908 - Rename current onEngagement to onLegacyEngagement r=mak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D206251
This commit is contained in:
Karandeep
2024-04-09 13:07:23 +00:00
parent 645f79c496
commit d8690f18b5
35 changed files with 79 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
browser/components/urlbar/UrlbarProviderQuickSuggest.sys.mjs
View File

@@ -229,7 +229,7 @@ class ProviderQuickSuggest extends UrlbarProvider {
}
}
onEngagement(state, queryContext, details, controller) {
onLegacyEngagement(state, queryContext, details, controller) {
// Ignore engagements on other results that didn't end the session.
if (details.result?.providerName != this.name && details.isSessionOngoing) {
return;
@@ -486,8 +486,8 @@ class ProviderQuickSuggest extends UrlbarProvider {
* end of the engagement or that was dismissed. Null if no quick suggest
* result was present.
* @param {object} details
* The `details` object that was passed to `onEngagement()`. It must look
* like this: `{ selType, selIndex }`
* The `details` object that was passed to `onLegacyEngagement()`. It must
* look like this: `{ selType, selIndex }`
*/
#recordEngagement(queryContext, result, details) {
let resultSelType = "";
@@ -781,8 +781,8 @@ class ProviderQuickSuggest extends UrlbarProvider {
* True if the main part of the result's row was clicked; false if a button
* like help or dismiss was clicked or if no part of the row was clicked.
* @param {object} options.details
* The `details` object that was passed to `onEngagement()`. It must look
* like this: `{ selType, selIndex }`
* The `details` object that was passed to `onLegacyEngagement()`. It must
* look like this: `{ selType, selIndex }`
*/
#recordNavSuggestionTelemetry({
queryContext,