corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1698214 - Getting media permissions fails with Isolated Process r=geckoview-reviewers,calu

Browse Source 
Patch fixes:
* Fixes missing define of MOZ_ANDROID_CONTENT_SERVICE_ISOLATED_PROCESS

Patch opens for general availability in isolated process runs:
* MediaDelegateTest#testDeviceRecordingEventVideo
* MediaDelegateXOriginTest#testDeviceRecordingEventAudioAndVideoInXOriginIframe

Differential Revision: https://phabricator.services.mozilla.com/D244822
This commit is contained in:
Olivia Hall
2025-04-09 19:15:07 +00:00
parent 23931a237a
commit d57758e4b2
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/MediaDelegateTest.kt
View File

@@ -143,9 +143,6 @@ class MediaDelegateTest : BaseSessionTest() {
}
@Test fun testDeviceRecordingEventVideo() {
// TODO: needs bug 1700243
assumeThat(sessionRule.env.isIsolatedProcess, Matchers.equalTo(false))
mainSession.loadTestPath(HELLO_HTML_PATH)
mainSession.waitForPageStop()

4
mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/MediaDelegateXOriginTest.kt
View File

@@ -8,7 +8,6 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
import androidx.test.filters.MediumTest
import org.hamcrest.Matchers
import org.json.JSONObject
import org.junit.Assume.assumeThat
import org.junit.Test
import org.junit.runner.RunWith
import org.mozilla.geckoview.GeckoSession
@@ -163,9 +162,6 @@ class MediaDelegateXOriginTest : BaseSessionTest() {
}
@Test fun testDeviceRecordingEventAudioAndVideoInXOriginIframe() {
// TODO: needs bug 1700243
assumeThat(sessionRule.env.isIsolatedProcess, Matchers.equalTo(false))
mainSession.loadTestPath(GETUSERMEDIA_XORIGIN_CONTAINER_HTML_PATH)
mainSession.waitForPageStop()

10
mobile/android/moz.configure
View File

@@ -45,9 +45,17 @@ option(
help="Enable generating content process services with isolatedProcess=true",
default=False,
)
isIsolatedProcessEnabled = depends_if("MOZ_ANDROID_CONTENT_SERVICE_ISOLATED_PROCESS")(
lambda _: True
)
set_config(
"MOZ_ANDROID_CONTENT_SERVICE_ISOLATED_PROCESS",
depends_if("MOZ_ANDROID_CONTENT_SERVICE_ISOLATED_PROCESS")(lambda x: True),
isIsolatedProcessEnabled,
)
set_define(
"MOZ_ANDROID_CONTENT_SERVICE_ISOLATED_PROCESS",
isIsolatedProcessEnabled,
)
option(