corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 514585: Remove macro wrappers for js_NewPrinter and JS_InitArenaPool. r=igor

Browse Source 
These macros were intended to help avoid passing unused parameters
when JS_ARENAMETER is not defined, but they're not worth the trouble.
The unused parameter doesn't elicit warnings, and the performance
impact of passing the unneeded argument is negligible.

This also removes support for JS_ARENA_CONST_ALIGN_MASK, which is not
used.
This commit is contained in:
Jim Blandy
2009-11-18 13:33:53 -08:00
parent 673f58ca8e
commit d48dccd251
9 changed files with 36 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
js/src/jsopcode.h
View File

@@ -275,17 +275,9 @@ js_QuoteString(JSContext *cx, JSString *str, jschar quote);
* a GC'ed string.
*/
#ifdef JS_ARENAMETER
# define JS_NEW_PRINTER(cx, name, fun, indent, pretty, grouped) \
js_NewPrinter(cx, name, fun, indent, pretty, grouped)
#else
# define JS_NEW_PRINTER(cx, name, fun, indent, pretty, grouped) \
js_NewPrinter(cx, fun, indent, pretty, grouped)
#endif
extern JSPrinter *
JS_NEW_PRINTER(JSContext *cx, const char *name, JSFunction *fun,
uintN indent, JSBool pretty, JSBool grouped);
js_NewPrinter(JSContext *cx, const char *name, JSFunction *fun,
uintN indent, JSBool pretty, JSBool grouped);
extern void
js_DestroyPrinter(JSPrinter *jp);