Bug 353280 nsThread::PushEventQueue leaks queue if !queue->IsInitialized (nsEventQueue::nsEventQueue() : mMonitor(nsAutoMonitor::NewMonitor("xpcom.eventqueue")) fails)

patch by darin r=timeless
2006-10-16 08:02:37 +00:00
parent 56506fb19a
commit d33c94c677
1 changed files with 3 additions and 1 deletions
--- a/xpcom/threads/nsThread.cpp
+++ b/xpcom/threads/nsThread.cpp
@@ -562,8 +562,10 @@ NS_IMETHODIMP
 nsThread::PushEventQueue(nsIThreadEventFilter *filter)
 {
  nsChainedEventQueue *queue = new nsChainedEventQueue(filter);
-  if (!queue || !queue->IsInitialized())
+  if (!queue || !queue->IsInitialized()) {
+    delete queue;
    return NS_ERROR_OUT_OF_MEMORY;
+  }

  nsAutoLock lock(mLock);
  queue->mNext = mEvents;