corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1266128 - Rename about debugging Tab(s) to Panel(s). r=janx

Browse Source
This commit is contained in:
Alexandre Poirot
2016-05-03 09:06:31 -07:00
parent 65233c11ad
commit cfe75b5609
15 changed files with 89 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
devtools/client/aboutdebugging/components/aboutdebugging.js
View File

@@ -3,7 +3,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/* eslint-env browser */
/* globals AddonsTab, WorkersTab */
/* globals AddonsPanel, WorkersPanel */
"use strict";
@@ -11,38 +11,38 @@ const { createFactory, createClass, DOM: dom } =
require("devtools/client/shared/vendor/react");
const Services = require("Services");
const TabMenu = createFactory(require("./tab-menu"));
const PanelMenu = createFactory(require("./panel-menu"));
loader.lazyGetter(this, "AddonsTab",
() => createFactory(require("./addons-tab")));
loader.lazyGetter(this, "WorkersTab",
() => createFactory(require("./workers-tab")));
loader.lazyGetter(this, "AddonsPanel",
() => createFactory(require("./addons/panel")));
loader.lazyGetter(this, "WorkersPanel",
() => createFactory(require("./workers/panel")));
const Strings = Services.strings.createBundle(
"chrome://devtools/locale/aboutdebugging.properties");
const tabs = [{
const panels = [{
id: "addons",
panelId: "tab-addons",
panelId: "addons-panel",
name: Strings.GetStringFromName("addons"),
icon: "chrome://devtools/skin/images/debugging-addons.svg",
component: AddonsTab
component: AddonsPanel
}, {
id: "workers",
panelId: "tab-workers",
panelId: "workers-panel",
name: Strings.GetStringFromName("workers"),
icon: "chrome://devtools/skin/images/debugging-workers.svg",
component: WorkersTab
component: WorkersPanel
}];
const defaultTabId = "addons";
const defaultPanelId = "addons";
module.exports = createClass({
displayName: "AboutDebuggingApp",
getInitialState() {
return {
selectedTabId: defaultTabId
selectedPanelId: defaultPanelId
};
},
@@ -61,33 +61,33 @@ module.exports = createClass({
onHashChange() {
let hash = window.location.hash;
// Default to defaultTabId if no hash is provided.
let tabId = hash ? hash.substr(1) : defaultTabId;
let panelId = hash ? hash.substr(1) : defaultPanelId;
let isValid = tabs.some(t => t.id == tabId);
let isValid = panels.some(p => p.id == panelId);
if (isValid) {
this.setState({ selectedTabId: tabId });
this.setState({ selectedPanelId: panelId });
} else {
// If the current hash matches no valid category, navigate to the default
// tab.
this.selectTab(defaultTabId);
// panel.
this.selectPanel(defaultPanelId);
}
},
selectTab(tabId) {
window.location.hash = "#" + tabId;
selectPanel(panelId) {
window.location.hash = "#" + panelId;
},
render() {
let { client } = this.props;
let { selectedTabId } = this.state;
let selectTab = this.selectTab;
let { selectedPanelId } = this.state;
let selectPanel = this.selectPanel;
let selectedTab = tabs.find(t => t.id == selectedTabId);
let selectedPanel = panels.find(p => p.id == selectedPanelId);
return dom.div({ className: "app" },
TabMenu({ tabs, selectedTabId, selectTab }),
PanelMenu({ panels, selectedPanelId, selectPanel }),
dom.div({ className: "main-content" },
selectedTab.component({ client, id: selectedTab.panelId })
selectedPanel.component({ client, id: selectedPanel.panelId })
)
);
}