corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1958219. Remove some unused scroll parent fields. r=layout-reviewers,emilio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D244302
This commit is contained in:
Timothy Nikkel
2025-04-04 10:50:26 +00:00
parent 732eacece6
commit cbfdc953c7
4 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
layout/painting/nsDisplayList.cpp
View File

@@ -5364,7 +5364,6 @@ nsDisplaySubDocument::nsDisplaySubDocument(nsDisplayListBuilder* aBuilder,
nsDisplayOwnLayerFlags aFlags) nsDisplayOwnLayerFlags aFlags)
: nsDisplayOwnLayer(aBuilder, aFrame, aList, : nsDisplayOwnLayer(aBuilder, aFrame, aList,
aBuilder->CurrentActiveScrolledRoot(), aFlags), aBuilder->CurrentActiveScrolledRoot(), aFlags),
mScrollParentId(aBuilder->GetCurrentScrollParentId()),
mShouldFlatten(false), mShouldFlatten(false),
mSubDocFrame(aSubDocFrame) { mSubDocFrame(aSubDocFrame) {
MOZ_COUNT_CTOR(nsDisplaySubDocument); MOZ_COUNT_CTOR(nsDisplaySubDocument);

1
layout/painting/nsDisplayList.h
View File

@@ -5503,7 +5503,6 @@ class nsDisplaySubDocument : public nsDisplayOwnLayer {
void RemoveFrame(nsIFrame* aFrame) override; void RemoveFrame(nsIFrame* aFrame) override;
protected: protected:
ViewID mScrollParentId;
bool mForceDispatchToContentRegion{}; bool mForceDispatchToContentRegion{};
bool mShouldFlatten; bool mShouldFlatten;
nsSubDocumentFrame* mSubDocFrame; nsSubDocumentFrame* mSubDocFrame;

3
layout/tables/nsTableFrame.cpp
View File

@@ -7372,8 +7372,7 @@ nsDisplayTableBackgroundSet::nsDisplayTableBackgroundSet(
nsDisplayListBuilder* aBuilder, nsIFrame* aTable) nsDisplayListBuilder* aBuilder, nsIFrame* aTable)
: mBuilder(aBuilder), : mBuilder(aBuilder),
mColGroupBackgrounds(aBuilder), mColGroupBackgrounds(aBuilder),
mColBackgrounds(aBuilder), mColBackgrounds(aBuilder) {
mCurrentScrollParentId(aBuilder->GetCurrentScrollParentId()) {
mPrevTableBackgroundSet = mBuilder->SetTableBackgroundSet(this); mPrevTableBackgroundSet = mBuilder->SetTableBackgroundSet(this);
mozilla::DebugOnly<const nsIFrame*> reference = mozilla::DebugOnly<const nsIFrame*> reference =
mBuilder->FindReferenceFrameFor(aTable, &mToReferenceFrame); mBuilder->FindReferenceFrameFor(aTable, &mToReferenceFrame);

4
layout/tables/nsTableFrame.h
View File

@@ -95,9 +95,6 @@ class nsDisplayTableBackgroundSet {
} }
const ActiveScrolledRoot* GetTableASR() { return mTableASR; } const ActiveScrolledRoot* GetTableASR() { return mTableASR; }
layers::ScrollableLayerGuid::ViewID GetScrollParentId() {
return mCurrentScrollParentId;
}
private: private:
// This class is only used on stack, so we don't have to worry about leaking // This class is only used on stack, so we don't have to worry about leaking
@@ -114,7 +111,6 @@ class nsDisplayTableBackgroundSet {
nsTArray<nsTableColFrame*> mColumns; nsTArray<nsTableColFrame*> mColumns;
nsPoint mToReferenceFrame; nsPoint mToReferenceFrame;
nsRect mDirtyRect; nsRect mDirtyRect;
layers::ScrollableLayerGuid::ViewID mCurrentScrollParentId;
const DisplayItemClipChain* mCombinedTableClipChain; const DisplayItemClipChain* mCombinedTableClipChain;
const ActiveScrolledRoot* mTableASR; const ActiveScrolledRoot* mTableASR;