Bug 1875216 - part 2: Remove linting for XPCOMUtils.defineLazyGetter r=arai,Standard8,frontend-codestyle-reviewers,mossop

Differential Revision: https://phabricator.services.mozilla.com/D202127

docs/code-quality/lint/linters/eslint-plugin-mozilla/rules/use-chromeutils-definelazygetter.rst

@@ -1,22 +0,0 @@
-use-chromeutils-definelazygetter
-================================
-
-Require use of ``ChromeUtils.defineLazyGetter`` rather than ``XPCOMUtils.defineLazyGetter``.
-
-Examples of incorrect code for this rule:
------------------------------------------
-
-.. code-block:: js
-
-    XPCOMUtils.defineLazyGetter(lazy, "textEncoder", function () {
-        return new TextEncoder();
-    });
-
-Examples of correct code for this rule:
----------------------------------------
-
-.. code-block:: js
-
-    ChromeUtils.defineLazyGetter(lazy, "textEncoder", function () {
-        return new TextEncoder();
-    });

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -76,7 +76,6 @@ const coreRules = {
     "mozilla/reject-scriptableunicodeconverter": "warn",
     "mozilla/rejects-requires-await": "error",
     "mozilla/use-cc-etc": "error",
-    "mozilla/use-chromeutils-definelazygetter": "error",
     "mozilla/use-chromeutils-generateqi": "error",
     "mozilla/use-console-createInstance": "error",
     "mozilla/use-default-preference-values": "error",

tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js

@@ -18,7 +18,6 @@ const callExpressionDefinitions = [
   /^loader\.lazyGetter\((?:globalThis|this), "(\w+)"/,
   /^loader\.lazyServiceGetter\((?:globalThis|this), "(\w+)"/,
   /^loader\.lazyRequireGetter\((?:globalThis|this), "(\w+)"/,
-  /^XPCOMUtils\.defineLazyGetter\((?:globalThis|this), "(\w+)"/,
   /^ChromeUtils\.defineLazyGetter\((?:globalThis|this), "(\w+)"/,
   /^XPCOMUtils\.defineLazyPreferenceGetter\((?:globalThis|this), "(\w+)"/,
   /^XPCOMUtils\.defineLazyScriptGetter\((?:globalThis|this), "(\w+)"/,

tools/lint/eslint/eslint-plugin-mozilla/lib/index.js

@@ -75,7 +75,6 @@ const plugin = {
     "reject-top-level-await": require("./rules/reject-top-level-await"),
     "rejects-requires-await": require("./rules/rejects-requires-await"),
     "use-cc-etc": require("./rules/use-cc-etc"),
-    "use-chromeutils-definelazygetter": require("./rules/use-chromeutils-definelazygetter"),
     "use-chromeutils-generateqi": require("./rules/use-chromeutils-generateqi"),
     "use-console-createInstance": require("./rules/use-console-createInstance"),
     "use-default-preference-values": require("./rules/use-default-preference-values"),

tools/lint/eslint/eslint-plugin-mozilla/lib/rules/use-chromeutils-definelazygetter.js

@@ -1,58 +0,0 @@
-/**
- * @fileoverview Reject use of XPCOMUtils.defineLazyGetter in favor of ChromeUtils.defineLazyGetter.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-"use strict";
-
-function isIdentifier(node, id) {
-  return node && node.type === "Identifier" && node.name === id;
-}
-
-function isMemberExpression(node, object, member) {
-  return (
-    node.type === "MemberExpression" &&
-    isIdentifier(node.object, object) &&
-    isIdentifier(node.property, member)
-  );
-}
-
-module.exports = {
-  meta: {
-    docs: {
-      url: "https://firefox-source-docs.mozilla.org/code-quality/lint/linters/eslint-plugin-mozilla/rules/use-chromeutils-definelazygetter.html",
-    },
-    fixable: "code",
-    messages: {
-      useChromeUtilsDefineLazyGetter:
-        "Please use ChromeUtils.defineLazyGetter instead of XPCOMUtils.defineLazyGetter",
-    },
-    schema: [],
-    type: "problem",
-  },
-
-  create(context) {
-    return {
-      CallExpression(node) {
-        if (node.callee.type !== "MemberExpression") {
-          return;
-        }
-
-        let { callee } = node;
-
-        if (isMemberExpression(callee, "XPCOMUtils", "defineLazyGetter")) {
-          context.report({
-            node,
-            messageId: "useChromeUtilsDefineLazyGetter",
-            fix(fixer) {
-              return fixer.replaceText(callee, "ChromeUtils.defineLazyGetter");
-            },
-          });
-        }
-      },
-    };
-  },
-};

tools/lint/eslint/eslint-plugin-mozilla/lib/rules/valid-lazy.js

@@ -24,7 +24,6 @@ const callExpressionDefinitions = [
   /^loader\.lazyGetter\(lazy, "(\w+)"/,
   /^loader\.lazyServiceGetter\(lazy, "(\w+)"/,
   /^loader\.lazyRequireGetter\(lazy, "(\w+)"/,
-  /^XPCOMUtils\.defineLazyGetter\(lazy, "(\w+)"/,
   /^Integration\.downloads\.defineESModuleGetter\(lazy, "(\w+)"/,
   /^ChromeUtils\.defineLazyGetter\(lazy, "(\w+)"/,
   /^XPCOMUtils\.defineLazyPreferenceGetter\(lazy, "(\w+)"/,

tools/lint/eslint/eslint-plugin-mozilla/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {

tools/lint/eslint/eslint-plugin-mozilla/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-mozilla",
-  "version": "4.1.0",
+  "version": "4.2.0",
   "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",
   "keywords": [
     "eslint",

tools/lint/eslint/eslint-plugin-mozilla/tests/use-chromeutils-definelazygetter.js

@@ -1,34 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
- * http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-// ------------------------------------------------------------------------------
-// Requirements
-// ------------------------------------------------------------------------------
-
-var rule = require("../lib/rules/use-chromeutils-definelazygetter");
-var RuleTester = require("eslint").RuleTester;
-
-const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: "latest" } });
-
-// ------------------------------------------------------------------------------
-// Tests
-// ------------------------------------------------------------------------------
-
-function callError(messageId) {
-  return [{ messageId, type: "CallExpression" }];
-}
-
-ruleTester.run("use-chromeutils-definelazygetter", rule, {
-  valid: [
-    `ChromeUtils.defineLazyGetter(lazy, "textEncoder", function () { return new TextEncoder(); });`,
-  ],
-  invalid: [
-    {
-      code: `XPCOMUtils.defineLazyGetter(lazy, "textEncoder", function () { return new TextEncoder(); });`,
-      output: `ChromeUtils.defineLazyGetter(lazy, "textEncoder", function () { return new TextEncoder(); });`,
-      errors: callError("useChromeUtilsDefineLazyGetter"),
-    },
-  ],
-});