corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1867769 - Fix one left-over usage of checkbox variables that I thought was independent of the rest.

Browse Source 
MANUAL PUSH: Trivial fix CLOSED TREE
This commit is contained in:
Emilio Cobos Álvarez
2023-12-02 21:13:56 +01:00
parent 88e8bbe796
commit c9bf1fd2ae
3 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
browser/components/aboutwelcome/content-src/aboutwelcome.scss
View File

@@ -259,7 +259,6 @@ html {
--in-content-primary-button-background: rgb(0, 221, 255);
--in-content-primary-button-background-hover: rgb(128, 235, 255);
--in-content-primary-button-background-active: rgb(170, 242, 255);
--checkbox-checked-bgcolor: var(--in-content-primary-button-background);
--in-content-button-text-color: var(--in-content-page-color);
}
@@ -272,7 +271,6 @@ html {
--in-content-primary-button-background-active: #053E94;
--in-content-primary-button-border-color: transparent;
--in-content-primary-button-border-hover: transparent;
--checkbox-checked-bgcolor: var(--in-content-primary-button-background);
--in-content-button-text-color: var(--in-content-page-color);
}
@@ -1486,7 +1484,7 @@ html {
&.current {
opacity: 1;
border-color: var(--checkbox-checked-bgcolor);
border-color: var(--in-content-primary-button-background);
// This is the only step shown, so visually hide it to maintain spacing.
&:last-of-type:first-of-type {
@@ -1508,7 +1506,7 @@ html {
width: 100%;
height: 100%;
margin-inline: -1px;
background-color: var(--checkbox-checked-bgcolor);
background-color: var(--in-content-primary-button-background);
border: 0;
border-radius: 0;
opacity: 1;

6
browser/components/aboutwelcome/content/aboutwelcome.css
View File

@@ -987,7 +987,6 @@ html {
--in-content-primary-button-background: rgb(0, 221, 255);
--in-content-primary-button-background-hover: rgb(128, 235, 255);
--in-content-primary-button-background-active: rgb(170, 242, 255);
--checkbox-checked-bgcolor: var(--in-content-primary-button-background);
--in-content-button-text-color: var(--in-content-page-color);
}
.onboardingContainer .screen.dark-text {
@@ -999,7 +998,6 @@ html {
--in-content-primary-button-background-active: #053E94;
--in-content-primary-button-border-color: transparent;
--in-content-primary-button-border-hover: transparent;
--checkbox-checked-bgcolor: var(--in-content-primary-button-background);
--in-content-button-text-color: var(--in-content-page-color);
}
.onboardingContainer .screen:dir(rtl) {
@@ -2116,7 +2114,7 @@ html {
}
.onboardingContainer .steps .indicator.current {
opacity: 1;
border-color: var(--checkbox-checked-bgcolor);
border-color: var(--in-content-primary-button-background);
}
.onboardingContainer .steps .indicator.current:last-of-type:first-of-type {
opacity: 0;
@@ -2134,7 +2132,7 @@ html {
width: 100%;
height: 100%;
margin-inline: -1px;
background-color: var(--checkbox-checked-bgcolor);
background-color: var(--in-content-primary-button-background);
border: 0;
border-radius: 0;
opacity: 1;

2
browser/components/aboutwelcome/tests/browser/browser_aboutwelcome_configurable_ui.js
View File

@@ -550,7 +550,7 @@ add_task(async function test_aboutwelcome_with_progress_bar() {
const indicatorStyles = content.window.getComputedStyle(indicator);
for (let [key, val] of Object.entries({
// The filled "completed" element should have
// `background-color: var(--checkbox-checked-bgcolor);`
// `background-color: var(--in-content-primary-button-background);`
"background-color": "rgb(0, 97, 224)",
// Base progress bar step styles.
height: "6px",