Bug 1937636 - Add a profiler feature for recording flow markers. r=profiler-reviewers,julienw
Recording flow markers can be somewhat expensive because it can add a lot of markers. e.g. a two markers for each microtask, markers for the hang reporter between each runnable etc. This adds a feature flag that we so we can conditionally emit these markers. Differential Revision: https://phabricator.services.mozilla.com/D232265
This commit is contained in:
@@ -577,6 +577,13 @@ const featureDescriptions = [
|
|||||||
value: "sandbox",
|
value: "sandbox",
|
||||||
title: "Report sandbox syscalls and logs in the profiler.",
|
title: "Report sandbox syscalls and logs in the profiler.",
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
name: "Flows",
|
||||||
|
value: "flows",
|
||||||
|
title:
|
||||||
|
"Include all flow-related markers. These markers show the program flow better but " +
|
||||||
|
"can cause more overhead in some places than normal.",
|
||||||
|
},
|
||||||
];
|
];
|
||||||
|
|
||||||
module.exports = {
|
module.exports = {
|
||||||
|
|||||||
@@ -250,7 +250,12 @@ class MOZ_RAII AutoProfilerStats {
|
|||||||
\
|
\
|
||||||
MACRO(26, "sandbox", Sandbox, \
|
MACRO(26, "sandbox", Sandbox, \
|
||||||
"Report sandbox syscalls and logs in the " \
|
"Report sandbox syscalls and logs in the " \
|
||||||
"profiler.")
|
"profiler.") \
|
||||||
|
\
|
||||||
|
MACRO(27, "flows", Flows, \
|
||||||
|
"Include all flow-related markers. These markers show the program" \
|
||||||
|
"better but can cause more overhead in some places than normal.")
|
||||||
|
|
||||||
// *** Synchronize with lists in ProfilerState.h and geckoProfiler.json ***
|
// *** Synchronize with lists in ProfilerState.h and geckoProfiler.json ***
|
||||||
|
|
||||||
struct ProfilerFeature {
|
struct ProfilerFeature {
|
||||||
|
|||||||
@@ -50,7 +50,8 @@
|
|||||||
"bandwidth",
|
"bandwidth",
|
||||||
"memory",
|
"memory",
|
||||||
"tracing",
|
"tracing",
|
||||||
"sandbox"
|
"sandbox",
|
||||||
|
"flows"
|
||||||
]
|
]
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -131,7 +131,12 @@
|
|||||||
\
|
\
|
||||||
MACRO(26, "sandbox", Sandbox, \
|
MACRO(26, "sandbox", Sandbox, \
|
||||||
"Report sandbox syscalls and logs in the " \
|
"Report sandbox syscalls and logs in the " \
|
||||||
"profiler.")
|
"profiler.") \
|
||||||
|
\
|
||||||
|
MACRO(27, "flows", Flows, \
|
||||||
|
"Include all flow-related markers. These markers show the program" \
|
||||||
|
"better but can cause more overhead in some places than normal.")
|
||||||
|
|
||||||
// *** Synchronize with lists in BaseProfilerState.h and geckoProfiler.json ***
|
// *** Synchronize with lists in BaseProfilerState.h and geckoProfiler.json ***
|
||||||
|
|
||||||
struct ProfilerFeature {
|
struct ProfilerFeature {
|
||||||
|
|||||||
Reference in New Issue
Block a user