corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1964823 - Introduce AutoTypeRef::Take to simplify code r=padenot,media-playback-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D248140
This commit is contained in:
CM
2025-05-08 19:05:00 +00:00
committed by cchang@mozilla.com
parent af987a3550
commit c8711878f8
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
dom/media/platforms/apple/AppleUtils.h
View File

@@ -134,15 +134,11 @@ class AutoTypeRef {
} }
// Move constructor // Move constructor
AutoTypeRef(AutoTypeRef<T, Traits>&& aOther) : mObj(aOther.mObj) { AutoTypeRef(AutoTypeRef<T, Traits>&& aOther) : mObj(aOther.Take()) {}
aOther.mObj = Traits::InvalidValue();
}
// Move assignment // Move assignment
AutoTypeRef<T, Traits>& operator=(const AutoTypeRef<T, Traits>&& aOther) { AutoTypeRef<T, Traits>& operator=(const AutoTypeRef<T, Traits>&& aOther) {
ReleaseIfNeeded(); Reset(aOther.Take(), AutoTypePolicy::NoRetain);
mObj = aOther.mObj;
aOther.mObj = Traits::InvalidValue();
return *this; return *this;
} }
@@ -172,6 +168,12 @@ class AutoTypeRef {
} }
private: private:
T Take() {
T obj = mObj;
mObj = Traits::InvalidValue();
return obj;
}
void ReleaseIfNeeded() { void ReleaseIfNeeded() {
if (mObj != Traits::InvalidValue()) { if (mObj != Traits::InvalidValue()) {
Traits::Release(mObj); Traits::Release(mObj);