corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1742438 - Part 10: Remove mExecutionResult; r=asuth

Browse Source 
This field is no longer necessary, as we are removing executed scripts from our list of scripts to
execute, so we cannot enter a state where something may be executed twice.

Differential Revision: https://phabricator.services.mozilla.com/D146182
This commit is contained in:
Yulia Startsev
2022-07-14 17:07:28 +00:00
parent 4ff841bf0f
commit c7f4582139
2 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dom/workers/ScriptLoader.cpp
View File

@@ -899,7 +899,6 @@ bool WorkerScriptLoader::EvaluateScript(JSContext* aCx,
WorkerLoadContext* loadContext = aRequest->GetWorkerLoadContext(); WorkerLoadContext* loadContext = aRequest->GetWorkerLoadContext();
NS_ASSERTION(loadContext->mExecutionScheduled, "Should be scheduled!"); NS_ASSERTION(loadContext->mExecutionScheduled, "Should be scheduled!");
NS_ASSERTION(!loadContext->mExecutionResult, "Should not have executed yet!");
MOZ_ASSERT(!mRv.Failed(), "Who failed it and why?"); MOZ_ASSERT(!mRv.Failed(), "Who failed it and why?");
mRv.MightThrowJSException(); mRv.MightThrowJSException();
@@ -954,7 +953,6 @@ bool WorkerScriptLoader::EvaluateScript(JSContext* aCx,
mRv.StealExceptionFromJSContext(aCx); mRv.StealExceptionFromJSContext(aCx);
return false; return false;
} }
loadContext->mExecutionResult = true;
return true; return true;
} }

1
dom/workers/loader/WorkerLoadContext.h
View File

@@ -61,7 +61,6 @@ class WorkerLoadContext : public JS::loader::LoadContextBase {
RefPtr<workerinternals::loader::CacheCreator> GetCacheCreator(); RefPtr<workerinternals::loader::CacheCreator> GetCacheCreator();
bool mExecutionScheduled = false; bool mExecutionScheduled = false;
bool mExecutionResult = false;
Maybe<nsString> mSourceMapURL; Maybe<nsString> mSourceMapURL;