Bug 1626570 - Improve handling of copying arrays in dom/html/. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D73647
2020-05-07 08:09:51 +00:00
parent 3c59a51cdb
commit c60d689f7c
3 changed files with 5 additions and 6 deletions
--- a/dom/html/HTMLInputElement.cpp
+++ b/dom/html/HTMLInputElement.cpp
@@ -6803,8 +6803,7 @@ void HTMLInputElement::SetFilePickerFiltersFromAccept(

  // Remove similar filters
  // Iterate over a copy, as we might modify the original filters list
-  nsTArray<nsFilePickerFilter> filtersCopy;
-  filtersCopy = filters;
+  const nsTArray<nsFilePickerFilter> filtersCopy = filters.Clone();
  for (uint32_t i = 0; i < filtersCopy.Length(); ++i) {
    const nsFilePickerFilter& filterToCheck = filtersCopy[i];
    if (filterToCheck.mFilterMask) {