Bug 941321 - try-finally all of Australis' begin/endBatchUpdate calls, r=mconley

2013-11-28 20:04:51 +01:00
parent 5bef7f5a30
commit c5f3b61dbd
4 changed files with 227 additions and 200 deletions
--- a/browser/components/customizableui/content/panelUI.js
+++ b/browser/components/customizableui/content/panelUI.js
@@ -220,8 +220,11 @@ const PanelUI = {
        CustomizableUI.registerMenuPanel(this.contents);
      } else {
        this.beginBatchUpdate();
-        CustomizableUI.registerMenuPanel(this.contents);
-        this.endBatchUpdate();
+        try {
+          CustomizableUI.registerMenuPanel(this.contents);
+        } finally {
+          this.endBatchUpdate();
+        }
      }
      this.panel.hidden = false;
    }.bind(this)).then(null, Cu.reportError);