corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1448586 - Avoid useless use of NS_LITERAL_CSTRING when prefixing query string with question mark. r=smaug.

Browse Source 
MozReview-Commit-ID: Cy8zkNWjsXM
This commit is contained in:
Henri Sivonen
2018-03-24 21:16:51 +02:00
parent 9eada7c633
commit c448c3c960
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
dom/base/Link.cpp
View File

@@ -737,7 +737,8 @@ Link::GetSearch(nsAString &_search)
nsAutoCString search; nsAutoCString search;
nsresult rv = url->GetQuery(search); nsresult rv = url->GetQuery(search);
if (NS_SUCCEEDED(rv) && !search.IsEmpty()) { if (NS_SUCCEEDED(rv) && !search.IsEmpty()) {
CopyUTF8toUTF16(NS_LITERAL_CSTRING("?") + search, _search); _search.Assign(u'?');
AppendUTF8toUTF16(search, _search);
} }
} }

3
dom/url/URLMainThread.cpp
View File

@@ -427,7 +427,8 @@ URLMainThread::GetSearch(nsAString& aSearch, ErrorResult& aRv) const
rv = mURI->GetQuery(search); rv = mURI->GetQuery(search);
if (NS_SUCCEEDED(rv) && !search.IsEmpty()) { if (NS_SUCCEEDED(rv) && !search.IsEmpty()) {
CopyUTF8toUTF16(NS_LITERAL_CSTRING("?") + search, aSearch); aSearch.Assign(u'?');
AppendUTF8toUTF16(search, aSearch);
} }
} }

3
dom/url/URLWorker.cpp
View File

@@ -1115,7 +1115,8 @@ URLWorker::GetSearch(nsAString& aSearch, ErrorResult& aRv) const
rv = mStdURL->GetQuery(search); rv = mStdURL->GetQuery(search);
if (NS_SUCCEEDED(rv) && !search.IsEmpty()) { if (NS_SUCCEEDED(rv) && !search.IsEmpty()) {
CopyUTF8toUTF16(NS_LITERAL_CSTRING("?") + search, aSearch); aSearch.Assign(u'?');
AppendUTF8toUTF16(search, aSearch);
} }
return; return;
} }