Bug 1708228 - Part 3: Remove aNotify from HTMLInputElement::VisitGroup r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D113807
This commit is contained in:
Kagami Sascha Rosylight
2021-04-30 11:25:23 +00:00
parent 7c44e8d4f5
commit c3d50e2789
2 changed files with 7 additions and 8 deletions

View File

@@ -2772,7 +2772,7 @@ void HTMLInputElement::DoSetCheckedChanged(bool aCheckedChanged, bool aNotify) {
if (mCheckedChanged != aCheckedChanged) {
nsCOMPtr<nsIRadioVisitor> visitor =
new nsRadioSetCheckedChangedVisitor(aCheckedChanged);
VisitGroup(visitor, aNotify);
VisitGroup(visitor);
}
} else {
SetCheckedChangedInternal(aCheckedChanged);
@@ -2957,7 +2957,7 @@ void HTMLInputElement::SetCheckedInternal(bool aChecked, bool aNotify) {
// radios to have the chance to update its states, e.g., :indeterminate.
if (mType == NS_FORM_INPUT_RADIO) {
nsCOMPtr<nsIRadioVisitor> visitor = new nsRadioUpdateStateVisitor(this);
VisitGroup(visitor, aNotify);
VisitGroup(visitor);
}
}
@@ -6089,7 +6089,7 @@ void HTMLInputElement::AddedToRadioGroup() {
nsCOMPtr<nsIRadioVisitor> visitor =
new nsRadioGetCheckedChangedVisitor(&checkedChanged, this);
VisitGroup(visitor, notify);
VisitGroup(visitor);
SetCheckedChangedInternal(checkedChanged);
@@ -6124,7 +6124,7 @@ void HTMLInputElement::WillRemoveFromRadioGroup() {
container->SetCurrentRadioButton(name, nullptr);
nsCOMPtr<nsIRadioVisitor> visitor = new nsRadioUpdateStateVisitor(this);
VisitGroup(visitor, true);
VisitGroup(visitor);
}
// Remove this radio from its group in the container.
@@ -6204,8 +6204,7 @@ bool HTMLInputElement::IsHTMLFocusable(bool aWithMouse, bool* aIsFocusable,
return false;
}
nsresult HTMLInputElement::VisitGroup(nsIRadioVisitor* aVisitor,
bool aFlushContent) {
nsresult HTMLInputElement::VisitGroup(nsIRadioVisitor* aVisitor) {
nsIRadioGroupContainer* container = GetRadioGroupContainer();
if (container) {
nsAutoString name;
@@ -6516,7 +6515,7 @@ void HTMLInputElement::UpdateValueMissingValidityStateForRadio(
nsAutoScriptBlocker scriptBlocker;
nsCOMPtr<nsIRadioVisitor> visitor =
new nsRadioSetValueMissingState(this, valueMissing, notify);
VisitGroup(visitor, notify);
VisitGroup(visitor);
}
}