corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1890427 - Part 8: Use an observer to regenerate backups on permission removal. r=backup-reviewers,kpatenio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D218878
This commit is contained in:
Mike Conley
2024-09-18 13:32:10 +00:00
parent 1e876ebf64
commit c38ff72c4c
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
browser/components/backup/BackupService.sys.mjs
View File

@@ -3167,6 +3167,7 @@ export class BackupService extends EventTarget {
Services.obs.addObserver(this.#observer, "passwordmgr-storage-changed"); Services.obs.addObserver(this.#observer, "passwordmgr-storage-changed");
Services.obs.addObserver(this.#observer, "formautofill-storage-changed"); Services.obs.addObserver(this.#observer, "formautofill-storage-changed");
Services.obs.addObserver(this.#observer, "sanitizer-sanitization-complete"); Services.obs.addObserver(this.#observer, "sanitizer-sanitization-complete");
Services.obs.addObserver(this.#observer, "perm-changed");
Services.obs.addObserver(this.#observer, "quit-application-granted"); Services.obs.addObserver(this.#observer, "quit-application-granted");
} }
@@ -3197,7 +3198,11 @@ export class BackupService extends EventTarget {
Services.obs.removeObserver(this.#observer, "passwordmgr-storage-changed"); Services.obs.removeObserver(this.#observer, "passwordmgr-storage-changed");
Services.obs.removeObserver(this.#observer, "formautofill-storage-changed"); Services.obs.removeObserver(this.#observer, "formautofill-storage-changed");
Services.obs.removeObserver(this.#observer, "sanitizer-sanitization-complete"); Services.obs.removeObserver(
this.#observer,
"sanitizer-sanitization-complete"
);
Services.obs.removeObserver(this.#observer, "perm-changed");
Services.obs.removeObserver(this.#observer, "quit-application-granted"); Services.obs.removeObserver(this.#observer, "quit-application-granted");
this.#observer = null; this.#observer = null;
@@ -3248,6 +3253,12 @@ export class BackupService extends EventTarget {
this.#debounceRegeneration(); this.#debounceRegeneration();
break; break;
} }
case "perm-changed": {
if (data == "deleted") {
this.#debounceRegeneration();
}
break;
}
} }
} }

20
browser/components/backup/tests/xpcshell/test_BackupService_regeneration.js
View File

@@ -455,3 +455,23 @@ add_task(async function test_sanitization() {
await Sanitizer.sanitize(["siteSettings"]); await Sanitizer.sanitize(["siteSettings"]);
}, "Saw regeneration on sanitization of site settings."); }, "Saw regeneration on sanitization of site settings.");
}); });
/**
* Tests that backup regeneration occurs after a permission is removed.
*/
add_task(async function test_permission_removed() {
let principal =
Services.scriptSecurityManager.createContentPrincipalFromOrigin(
"https://test-permission-site.com"
);
const PERMISSION_TYPE = "desktop-notification";
Services.perms.addFromPrincipal(
principal,
PERMISSION_TYPE,
Services.perms.ALLOW_ACTION
);
await expectRegeneration(async () => {
Services.perms.removeFromPrincipal(principal, PERMISSION_TYPE);
}, "Saw regeneration on permission removal.");
});