corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1896514 - Make mach lint accommodate Windows drive case differences. r=ahal

Browse Source 
We hand-roll to avoid `os.path.realpath` invoking potentially
expensive filesystem APIs.

Differential Revision: https://phabricator.services.mozilla.com/D210230
This commit is contained in:
Nick Alexander
2024-05-28 20:29:38 +00:00
parent d5c46e45d6
commit c1d63c5fb2
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
python/mozlint/mozlint/pathutils.py
View File

@@ -3,10 +3,13 @@
# file, You can obtain one at http://mozilla.org/MPL/2.0/. # file, You can obtain one at http://mozilla.org/MPL/2.0/.
import os import os
import sys
from mozpack import path as mozpath from mozpack import path as mozpath
from mozpack.files import FileFinder from mozpack.files import FileFinder
_is_windows = sys.platform == "cygwin" or (sys.platform == "win32" and os.sep == "\\")
class FilterPath(object): class FilterPath(object):
"""Helper class to make comparing and matching file paths easier.""" """Helper class to make comparing and matching file paths easier."""
@@ -64,6 +67,13 @@ class FilterPath(object):
if len(parts_a) > len(parts_b): if len(parts_a) > len(parts_b):
return False return False
if _is_windows and parts_a:
# Normalize case of drive letters, without invoking the file system.
if parts_a[0].endswith(":"):
parts_a[0] = parts_a[0].upper()
if parts_b[0].endswith(":"):
parts_b[0] = parts_b[0].upper()
for i, part in enumerate(parts_a): for i, part in enumerate(parts_a):
if part != parts_b[i]: if part != parts_b[i]:
return False return False